Implement call operator.

lib/compiler/implementation/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer {
   final Compiler compiler;
 
@@ skipping 17 matching lines @@
         usedGlobals = new Map<String, int>(),
         usedPrivateNames = new Map<String, Set<LibraryElement>>(),
         shortPrivateNameOwners = new Map<String, LibraryElement>();
 
   final String CURRENT_ISOLATE = @'$';
   final String ISOLATE = 'Isolate';
   final String ISOLATE_PROPERTIES = @"$isolateProperties";
   /** Some closures must contain their name. The name is stored in
     * [STATIC_CLOSURE_NAME_NAME]. */
   final String STATIC_CLOSURE_NAME_NAME = @'$name';
-  final SourceString CLOSURE_INVOCATION_NAME = const SourceString(@'$call');
+  final SourceString CLOSURE_INVOCATION_NAME = const SourceString('call');
 
 
   String closureInvocationName(Selector selector) {
     // TODO(floitsch): mangle, while not conflicting with instance names.
     return instanceMethodInvocationName(null, CLOSURE_INVOCATION_NAME,
                                         selector);
   }
 
   /** Returns a non-unique name for the given closure element. */
   String closureName(Element element) {
@@ skipping 51 matching lines @@
       // If a library name does not start with the [LIBRARY_PREFIX] then our
       // assumptions about clashing with mangled private members do not hold.
       assert(libName.startsWith(LIBRARY_PREFIX));
       return '_$libName$nameString';
     } else {
       return name.slowToString();
     }
   }
 
   String instanceMethodName(LibraryElement lib, SourceString name, int arity) {
+    if (name == const SourceString("call")) name = CLOSURE_INVOCATION_NAME;

[kasperl, 2012/08/10 10:16:28]

What's the intent here? If the name is already 'call' you want to make it
'call'? Weird. I guess you want to map the user-defined 'call' method to
whatever we've decided to call the method we use to invoke closures. Maybe
introduce a constant for the RHS of the comparison to make it clearer?

[floitsch, 2012/08/10 12:19:16]

Changed:
CLOSURE_INVOCATION_NAME is now initialized to Compiler.CALL_OPERATOR_NAME.
(which is set to "call").

The 'if' here and below has been removed.

     return '${privateName(lib, name)}\$$arity';
   }
 
   String instanceMethodInvocationName(LibraryElement lib, SourceString name,
                                       Selector selector) {
+    if (name == const SourceString("call")) name = CLOSURE_INVOCATION_NAME;
     // TODO(floitsch): mangle, while preserving uniqueness.
     StringBuffer buffer = new StringBuffer();
     List<SourceString> names = selector.getOrderedNamedArguments();
     for (SourceString argumentName in names) {
       buffer.add(@'$');
       argumentName.printOn(buffer);
     }
     return '${privateName(lib, name)}\$${selector.argumentCount}$buffer';
   }
 
@@ skipping 158 matching lines @@
   }
 
   String safeName(String name) {
     if (jsReserved.contains(name) || name.startsWith('\$')) {
       name = "\$$name";
       assert(!jsReserved.contains(name));
     }
     return name;
   }
 }