Issue 10834269: gestures: Some more event cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834269: gestures: Some more event cleanup. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gestures: Some more event cleanup. Now that ui::TouchEvent and ui::GestureEvent are both concrete types, the gesture recognizer can create the events on its own, and does not have to depend on platform implementation. BUG=125937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151052

Patch Set 1 : . #

Patch Set 2 : tot-merge #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -145 lines)			Patch
M	ash/launcher/launcher_tooltip_manager_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/wm/system_gesture_event_filter_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/wm/user_activity_detector_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.cc	View	3 chunks	+37 lines, -75 lines	0 comments	Download
M	ui/aura/root_window.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	ui/aura/root_window.cc	View	2 chunks	+2 lines, -20 lines	0 comments	Download
M	ui/base/event.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/event.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/gestures/gesture_recognizer_impl.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/base/gestures/gesture_types.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

This is a follow-up CL to http://codereview.chromium.org/10824247/. I kept it separate so review is easier. ...

8 years, 4 months ago (2012-08-10 05:16:08 UTC) #1

LGTM

Expand Messages | Collapse Messages