Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 10834262: Enabled SignInAfterInit test. (Closed)

Created:
8 years, 4 months ago by Andrew T Wilson (Slow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Enabled SignInAfterInit test. Also added comment about how to use TokenService from tests. BUG=141123 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/policy/user_policy_signin_service_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/signin/token_service.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andrew T Wilson (Slow)
This is a test that was left disabled from my previous CL because I incorrectly ...
8 years, 4 months ago (2012-08-10 04:04:32 UTC) #1
Mattias Nissler (ping if slow)
LGTM
8 years, 4 months ago (2012-08-10 06:53:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10834262/1
8 years, 4 months ago (2012-08-10 16:17:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 10834262-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-10 16:17:07 UTC) #4
Andrew T Wilson (Slow)
willchan: PTAL at the new DCHECK I added to net/url_fetcher_core.cc - I need your OWNERS ...
8 years, 4 months ago (2012-08-10 17:26:08 UTC) #5
Andrew T Wilson (Slow)
Not sure if Will is around, so adding some more net/OWNERS folks to review my ...
8 years, 4 months ago (2012-08-10 21:01:43 UTC) #6
eroman
src/net/* LGTM
8 years, 4 months ago (2012-08-10 21:04:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10834262/1
8 years, 4 months ago (2012-08-10 23:42:03 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-11 02:02:23 UTC) #9
Change committed as 151180

Powered by Google App Engine
This is Rietveld 408576698