chrome/common/extensions/extension.cc - Issue 10834261: Move chrome.experimental.app.onLaunched event handler to chrome.app.runtime.onLaunched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10834261: Move chrome.experimental.app.onLaunched event handler to chrome.app.runtime.onLaunched. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Synced/merged, resolved conflicts. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_api.cc ('K') | « chrome/common/extensions/docs/static/first_app.html ('k') | chrome/common/extensions/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index fffe1f163a208d3cd8e58229db6f6abdceb6c519..03ef7b6c0fde33ac88ee3535930121ad6d57afd2 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -3130,8 +3130,10 @@ bool Extension::InitFromValue(int flags, string16* error) {

// TODO(jeremya/kalman) do this via the features system by exposing the

// app.window API to platform apps, with no dependency on any permissions.

// See http://crbug.com/120069.

- if (is_platform_app())

+ if (is_platform_app()) {

+ api_permissions.insert(APIPermission::kAppRuntime);

api_permissions.insert(APIPermission::kAppWindow);

+ }

APIPermissionSet optional_api_permissions;

URLPatternSet optional_host_permissions;