Move chrome.experimental.app.onLaunched event handler to chrome.app.runtime.onLaunched.

Move chrome.experimental.app.onLaunched event handler to chrome.app.runtime.onLaunched.

Other: 1) Made the "api.runtime" permission set implicitly (i.e., it is not required in an app's manifest.json).  2) Updated tests and regenerated docs.


BUG=139253
NOTRY=true
TBR=brettw@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151580

[Mihai Parparita -not on Chrome, 2012-08-09 22:13:52]

Antony, do you mind taking this review?

[asargent_no_longer_on_chrome, 2012-08-09 22:17:22]

sure, I'll take a look

[asargent_no_longer_on_chrome, 2012-08-10 00:09:10]

https://chromiumcodereview.appspot.com/10834261/diff/4002/chrome/common/exten...
File chrome/common/extensions/api/app_runtime.json (right):

https://chromiumcodereview.appspot.com/10834261/diff/4002/chrome/common/exten...
chrome/common/extensions/api/app_runtime.json:7: "namespace":"app.runtime",
nit: can you put this in an IDL instead of a .json file? See
chrome/common/extensions/api/*.idl for examples, and feel free to ping me via
chat if you run into any problems. 

It should be something like the following:


namespace app.runtime {

  callback NullCallback = void ();

  // A WebIntents intent object.
  [inline_doc] dictionary IntentData {
    // The WebIntent being invoked.
    DOMString action;

    // The MIME type of the data.
    DOMString type;
  
    // Data associated with the intent.
    any data;

    // Callback to be compatible with WebIntents.
    NullCallback postResult;

    // Callback to be compatible with WebIntents.
    NullCallback postFailure;
  };

  // Optional data for the launch.
  [inline_doc] dictionary LaunchData {    
    IntentData intent;
  }

  interface Events {
    static void onLaunched(optional OnLaunchedInfo info);
  };

};

https://chromiumcodereview.appspot.com/10834261/diff/4002/chrome/common/exten...
File chrome/common/extensions/api/extension_api.cc (right):

https://chromiumcodereview.appspot.com/10834261/diff/4002/chrome/common/exten...
chrome/common/extensions/api/extension_api.cc:348:
IDR_EXTENSION_API_JSON_APP_RUNTIME));
if you switch to an idl file, you will not need this line

[miu, 2012-08-10 02:34:18]

Changes done (now via IDL).

BTW--Was I correct to assume the chrome.app.runtime API should be available on
the "stable" channel?  Or, is "dev" still more appropriate?

[asargent_no_longer_on_chrome, 2012-08-10 18:43:58]

LGTM w/ one nit

I talked with Mihai, and we think it's fine to leave this marked as stable
channel since we want it in stable for M23 anyway.

https://chromiumcodereview.appspot.com/10834261/diff/1005/chrome/browser/exte...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.cc (right):

https://chromiumcodereview.appspot.com/10834261/diff/1005/chrome/browser/exte...
chrome/browser/extensions/api/app_runtime/app_runtime_api.cc:50: //
common/extensions/api/app_runtime.idl.
nit: can you make sure there is a bug filed in crbug.com about this, and
reference the bug number here in the comment? (It should be Area-Interansl,
Feature-Apps)

(same thing below)

[commit-bot: I haz the power, 2012-08-14 04:09:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/1007

[miu, 2012-08-14 04:10:43]

On 2012/08/10 18:43:58, Antony Sargent wrote:
> chrome/browser/extensions/api/app_runtime/app_runtime_api.cc:50: //
> nit: can you make sure there is a bug filed in http://crbug.com about this,
and
> reference the bug number here in the comment? (It should be Area-Interansl,
> Feature-Apps)

Done.  http://crbug.com/142540

[commit-bot: I haz the power, 2012-08-14 04:11:33]

Presubmit check for 10834261-1007 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

./integration_test.py failed!
Command ./integration_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
ERROR:root:docs/server2/templates/public/junk.html
.E.E
======================================================================
ERROR: testAll (__main__.IntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./integration_test.py", line 88, in testAll
    Handler(request, response, local_path='../..').get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 157, in get
    self._NavigateToPath(path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 135, in _NavigateToPath
    self.response)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/server_instance.py",
line 52, in Get
    content = templates.Render(path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/template_data_source.py",
line 118, in Render
    'false': False
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 755, in render
    self._topNode.render(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 251, in render
    self._content.render(contentRenderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 484, in render
    context = valueId.resolve(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 148, in resolve
    resolved = self._resolveFromContexts(renderState.globalContexts)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 155, in _resolveFromContexts
    resolved = self._resolveFromContext(context)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 167, in _resolveFromContext
    result = result.get(next)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/intro_data_source.py",
line 82, in get
    return self._cache.GetFromFile(base_path + '/' + real_path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/file_system_cache.py",
line 50, in GetFromFile
    self._cache[path] = self._CacheEntry(self._populate_function(cache_data),
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/intro_data_source.py",
line 69, in _MakeIntroDict
    'intro': Handlebar(intro),
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 607, in __init__
    raise ParseException("Template is empty", tokens.nextLine)
ParseException: Template is empty (line 1)

======================================================================
ERROR: testWarmupRequest (__main__.IntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./integration_test.py", line 112, in testWarmupRequest
    Handler(request, response, local_path='../..').get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 141, in get
    self._NavigateToPath('trunk/extensions/samples.html')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 135, in _NavigateToPath
    self.response)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/server_instance.py",
line 52, in Get
    content = templates.Render(path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/template_data_source.py",
line 118, in Render
    'false': False
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 755, in render
    self._topNode.render(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 282, in render
    node.render(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 251, in render
    self._content.render(contentRenderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 484, in render
    context = valueId.resolve(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 148, in resolve
    resolved = self._resolveFromContexts(renderState.globalContexts)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 155, in _resolveFromContexts
    resolved = self._resolveFromContext(context)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 167, in _resolveFromContext
    result = result.get(next)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 209, in get
    }.get(key, lambda: {})()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 208, in <lambda>
    'extensions': lambda: self._CreateSamplesDict('extensions')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 174, in _CreateSamplesDict
    self._samples_path + '/')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/file_system_cache.py",
line 68, in GetFromFileListing
    self._cache[path] = self._CacheEntry(self._populate_function(cache_data),
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 108, in _MakeSamplesList
    manifest_data = self._GetDataFromManifest(sample_path, file_system)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 70, in _GetDataFromManifest
    [locales_path + f + 'messages.json' for f in locales_dir]).Get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/memcache_file_system.py",
line 48, in Read
    new_items = self._file_system.Read(uncached, binary=binary).Get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/subversion_file_system.py",
line 18, in Read
    return Future(delegate=_AsyncFetchFuture(paths, self._fetcher, binary))
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/subversion_file_system.py",
line 33, in __init__
    self._fetches = [(path, fetcher.FetchAsync(path)) for path in paths]
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_url_fetcher.py",
line 36, in FetchAsync
    urlfetch.make_fetch_call(rpc, self._base_path + '/' + url)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_wrappers.py",
line 66, in make_fetch_call
    rpc.result = self.fetch(url)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_wrappers.py",
line 60, in fetch
    return self._Response(_GetConfiguration(url).fetch(url))
  File "./integration_test.py", line 46, in fetch
    return _ReadFile(path)
  File "./integration_test.py", line 23, in _ReadFile
    with open(path, 'r') as f:
IOError: [Errno 2] No such file or directory:
u'../../docs/examples/api/i18n/getMessage/_locales/.svn/messages.json'

----------------------------------------------------------------------
Ran 4 tests in 31.971s

FAILED (errors=2)


Presubmit checks took 36.6s to calculate.

[miu, 2012-08-14 04:44:42]

kalman@, I need your LGTM for the change to this file:

  chrome/chrome_renderer.gypi

Thanks,
Yuri

[Mihai Parparita -not on Chrome, 2012-08-14 04:55:34]

Ben isn't actually an OWNER for that directory, see
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/OWNERS for who you
need to bug.

Mihai

On Mon, Aug 13, 2012 at 9:44 PM, <miu@chromium.org> wrote:

> kalman@, I need your LGTM for the change to this file:
>
>   chrome/chrome_renderer.gypi
>
> Thanks,
> Yuri
>
>
>
https://chromiumcodereview.**appspot.com/10834261/<https://chromiumcodereview...
>

[not at google - send to devlin, 2012-08-14 04:58:47]

Yeah I'm not a chrome owner, and if it's just a gyp change you can tbr one of
the chrome owners.

But while I'm here; is the chrome.app.window availability bug fixed, because if
not this will be affected too.

[miu, 2012-08-14 05:09:53]

brettw@,

I added you as a TBR reviewer since I'm changing the following file:

  chrome/chrome_renderer.gypi

Thanks,
Yuri

[commit-bot: I haz the power, 2012-08-14 05:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/10231

[commit-bot: I haz the power, 2012-08-14 05:11:32]

Presubmit check for 10834261-10231 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
./integration_test.py failed!
Command ./integration_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
ERROR:root:docs/server2/templates/public/junk.html
...E
======================================================================
ERROR: testWarmupRequest (__main__.IntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./integration_test.py", line 112, in testWarmupRequest
    Handler(request, response, local_path='../..').get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 141, in get
    self._NavigateToPath('trunk/extensions/samples.html')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 135, in _NavigateToPath
    self.response)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/server_instance.py",
line 52, in Get
    content = templates.Render(path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/template_data_source.py",
line 118, in Render
    'false': False
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 755, in render
    self._topNode.render(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 282, in render
    node.render(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 251, in render
    self._content.render(contentRenderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 484, in render
    context = valueId.resolve(renderState)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 148, in resolve
    resolved = self._resolveFromContexts(renderState.globalContexts)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 155, in _resolveFromContexts
    resolved = self._resolveFromContext(context)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/third_party/handlebar/handlebar.py",
line 167, in _resolveFromContext
    result = result.get(next)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 209, in get
    }.get(key, lambda: {})()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 208, in <lambda>
    'extensions': lambda: self._CreateSamplesDict('extensions')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 174, in _CreateSamplesDict
    self._samples_path + '/')
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/file_system_cache.py",
line 68, in GetFromFileListing
    self._cache[path] = self._CacheEntry(self._populate_function(cache_data),
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 108, in _MakeSamplesList
    manifest_data = self._GetDataFromManifest(sample_path, file_system)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/samples_data_source.py",
line 70, in _GetDataFromManifest
    [locales_path + f + 'messages.json' for f in locales_dir]).Get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/memcache_file_system.py",
line 48, in Read
    new_items = self._file_system.Read(uncached, binary=binary).Get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/subversion_file_system.py",
line 18, in Read
    return Future(delegate=_AsyncFetchFuture(paths, self._fetcher, binary))
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/subversion_file_system.py",
line 33, in __init__
    self._fetches = [(path, fetcher.FetchAsync(path)) for path in paths]
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_url_fetcher.py",
line 36, in FetchAsync
    urlfetch.make_fetch_call(rpc, self._base_path + '/' + url)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_wrappers.py",
line 66, in make_fetch_call
    rpc.result = self.fetch(url)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/appengine_wrappers.py",
line 60, in fetch
    return self._Response(_GetConfiguration(url).fetch(url))
  File "./integration_test.py", line 46, in fetch
    return _ReadFile(path)
  File "./integration_test.py", line 23, in _ReadFile
    with open(path, 'r') as f:
IOError: [Errno 2] No such file or directory:
u'../../docs/examples/api/i18n/getMessage/_locales/.svn/messages.json'

----------------------------------------------------------------------
Ran 4 tests in 34.854s

FAILED (errors=1)


Presubmit checks took 39.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[not at google - send to devlin, 2012-08-14 05:14:21]

That presubmit check was supposed to be disabled but the patch which happened to
disable it got reverted for other reasons.

I'll fix it now.

[miu, 2012-08-14 05:19:41]

On 2012/08/14 05:14:21, kalman wrote:
> That presubmit check was supposed to be disabled but the patch which happened
to
> disable it got reverted for other reasons.
> 
> I'll fix it now.

Thank you.  :)

BTW--It's 10pm here, so I'll try again tomorrow morning.

[commit-bot: I haz the power, 2012-08-14 05:19:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/10231

[commit-bot: I haz the power, 2012-08-14 05:23:02]

Try job failure for 10834261-10231 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-14 05:25:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/10231

[commit-bot: I haz the power, 2012-08-14 05:26:59]

Try job failure for 10834261-10231 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[not at google - send to devlin, 2012-08-14 05:36:46]

Ok, some malformed patch failure that could be subversion related?

Possibly, maybe related to the server2 changes, so if after syncing and trying
to commit the patch again it doesn't work, try reverting the changes in the
server2 directly manually... and if that helps, comment out the call to
converter.py in build.py :(

and I'll look at it tomorrow.

[commit-bot: I haz the power, 2012-08-14 05:38:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/11006

[miu, 2012-08-14 05:43:43]

I think I fixed the patch problem.  At least, the builds are now reaching the
"compile" step.  :)

[commit-bot: I haz the power, 2012-08-14 09:10:39]

Try job failure for 10834261-11006 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, steps "browser_tests, content_browsertests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-14 16:43:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/13006

[commit-bot: I haz the power, 2012-08-14 21:07:12]

Try job failure for 10834261-13006 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-14 22:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/10834261/13006

[commit-bot: I haz the power, 2012-08-14 22:13:02]

Change committed as 151580

[Mihai Parparita -not on Chrome, 2012-08-14 22:28:07]

This isn't test flakiness, the failures are legitimate:

[25921:25921:0814/131403:3872586484:ERROR:extension_error_reporter.cc(56)]
Extension error: Could not load extension from
'/mnt/scratch0/b_used/build/slave/linux_chromeos/build/src/chrome/test/data/extensions/platform_apps/launch_2'.
Manifest is not valid JSON.  Line: 10, column: 2, Trailing comma not
allowed.

You left a trailing comma in
https://chromiumcodereview.appspot.com/10834261/diff/13006/chrome/test/data/e...

Mihai

On Tue, Aug 14, 2012 at 3:11 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>
https://chromium-status.**appspot.com/cq/miu@chromium.**org/10834261/13006<ht...
>
>
>
https://chromiumcodereview.**appspot.com/10834261/<https://chromiumcodereview...
>