Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10834255: Extensions Docs Server: Apps titles should show "Apps" instead of "Extensions" (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extensions Docs Server: Apps titles should show "Apps" instead of "Extensions" Templates now show "Apps" for apps and "Extensions" for extensions. BUG=141576 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151126

Patch Set 1 #

Total comments: 7

Patch Set 2 : fixes #

Messages

Total messages: 4 (0 generated)
cduvall
I'm not sure what other places need similar changes, I changed the parts of header_body ...
8 years, 4 months ago (2012-08-09 17:11:35 UTC) #1
not at google - send to devlin
lgtm, though the amount of "is_apps" here is distressing. It'll be hard to keep that ...
8 years, 4 months ago (2012-08-10 04:44:34 UTC) #2
cduvall
http://codereview.chromium.org/10834255/diff/1/chrome/common/extensions/docs/server2/templates/private/header_body.html File chrome/common/extensions/docs/server2/templates/private/header_body.html (right): http://codereview.chromium.org/10834255/diff/1/chrome/common/extensions/docs/server2/templates/private/header_body.html#newcode31 chrome/common/extensions/docs/server2/templates/private/header_body.html:31: <a href="faq.html" title="Answers to frequently asked questions about Google ...
8 years, 4 months ago (2012-08-10 21:45:30 UTC) #3
cduvall
8 years, 4 months ago (2012-08-10 21:46:22 UTC) #4
The rest of the is_apps changes are in:
https://chromiumcodereview.appspot.com/10825067/

Powered by Google App Engine
This is Rietveld 408576698