Issue 10834247: Use the correct oracle in TestContext::BuildBranch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834247: Use the correct oracle in TestContext::BuildBranch. (Closed)

Created:
8 years, 4 months ago by Sven Panne

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use the correct oracle in TestContext::BuildBranch. When inlining is being done, it is crucial to use the correct type feedback oracle with a given type feedback ID. To ensure this, TestContext now carries an oracle which is associated with the context's condition, and these are both used together in TestContext::BuildBranch. Note that in VisitReturnStatement and TryInline we are currently lucky that the oracles don't go out of sync in an observable way, but this will change when we inline setters. Therefore, there is no separate test case... Committed: https://code.google.com/p/v8/source/detail?r=12284

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/hydrogen.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download
	M	src/hydrogen.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 4 months ago (2012-08-09 11:42:28 UTC) #2

LGTM. As discussed offline, we cannot come up with a regression test for this.
But it will be covered by the upcoming setter inlining.

Expand Messages | Collapse Messages