Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chrome/test/functional/perf.cfg

Issue 10834239: Configuration file for Chrome perf and endure tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/test/functional/perf.py » ('j') | chrome/test/functional/perf.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Configuration file for pyauto perf tests.
dennis_jeffrey 2012/08/16 18:49:58 We should probably add the license header to the t
fdeng1 2012/08/17 06:39:34 Done.
2 # This file is used to specify google account credentials and
3 # custom google account, gmail, docs, plus urls if you don't want to use
4 # the public urls of these services. It is formatted as a python dictionary.
5 {
6 # Set to custom username/password if desired.
7 # If you are external to Google, you must set username/password.
8 # If you are internal to Google, you can leave them as None
9 # and tests will try to use internal credential file.
10 "username": None,
11 "password": None,
12 "google_account_url": "https://accounts.google.com",
dennis_jeffrey 2012/08/16 18:49:58 nit: add a blank line above this to enhance readab
dennis_jeffrey 2012/08/16 18:49:58 Should the google account url be None here? We sh
fdeng1 2012/08/17 06:39:34 Done.
13 # Settings below are only effective for perf_endure.py
dennis_jeffrey 2012/08/16 18:49:58 nit: add a blank line above this to enhance readab
fdeng1 2012/08/17 06:39:34 Done.
14 "gmail_url": "https://www.gmail.com",
15 "plus_url": "https://plus.google.com",
16 "docs_url": "https://drive.google.com",
dennis_jeffrey 2012/08/16 18:49:58 prefer single quotes over double quotes in lines 1
dennis_jeffrey 2012/08/16 18:49:58 should we initialize the gmail, plus, and docs URL
fdeng1 2012/08/17 06:39:34 Done.
fdeng1 2012/08/17 06:39:34 Yes, that sounds right. I changed them.
17 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/functional/perf.py » ('j') | chrome/test/functional/perf.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698