Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: media/filters/video_renderer_base.h

Issue 10834236: Replace Pipeline::kEnded state and HasEnded() methods with renderer-specific bools. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/filters/audio_renderer_impl_unittest.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
6 #define MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 6 #define MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 const PipelineStatusCB& error_cb, 59 const PipelineStatusCB& error_cb,
60 const TimeDeltaCB& get_time_cb, 60 const TimeDeltaCB& get_time_cb,
61 const TimeDeltaCB& get_duration_cb) OVERRIDE; 61 const TimeDeltaCB& get_duration_cb) OVERRIDE;
62 virtual void Play(const base::Closure& callback) OVERRIDE; 62 virtual void Play(const base::Closure& callback) OVERRIDE;
63 virtual void Pause(const base::Closure& callback) OVERRIDE; 63 virtual void Pause(const base::Closure& callback) OVERRIDE;
64 virtual void Flush(const base::Closure& callback) OVERRIDE; 64 virtual void Flush(const base::Closure& callback) OVERRIDE;
65 virtual void Preroll(base::TimeDelta time, 65 virtual void Preroll(base::TimeDelta time,
66 const PipelineStatusCB& cb) OVERRIDE; 66 const PipelineStatusCB& cb) OVERRIDE;
67 virtual void Stop(const base::Closure& callback) OVERRIDE; 67 virtual void Stop(const base::Closure& callback) OVERRIDE;
68 virtual void SetPlaybackRate(float playback_rate) OVERRIDE; 68 virtual void SetPlaybackRate(float playback_rate) OVERRIDE;
69 virtual bool HasEnded() OVERRIDE;
70 69
71 // PlatformThread::Delegate implementation. 70 // PlatformThread::Delegate implementation.
72 virtual void ThreadMain() OVERRIDE; 71 virtual void ThreadMain() OVERRIDE;
73 72
74 // Clients of this class (painter/compositor) should use GetCurrentFrame() 73 // Clients of this class (painter/compositor) should use GetCurrentFrame()
75 // obtain ownership of VideoFrame, it should always relinquish the ownership 74 // obtain ownership of VideoFrame, it should always relinquish the ownership
76 // by use PutCurrentFrame(). Current frame is not guaranteed to be non-NULL. 75 // by use PutCurrentFrame(). Current frame is not guaranteed to be non-NULL.
77 // It expects clients to use color-fill the background if current frame 76 // It expects clients to use color-fill the background if current frame
78 // is NULL. This could happen before pipeline is pre-rolled or during 77 // is NULL. This could happen before pipeline is pre-rolled or during
79 // pause/flush/preroll. 78 // pause/flush/preroll.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 233
235 // The last natural size |size_changed_cb_| was called with. 234 // The last natural size |size_changed_cb_| was called with.
236 gfx::Size last_natural_size_; 235 gfx::Size last_natural_size_;
237 236
238 DISALLOW_COPY_AND_ASSIGN(VideoRendererBase); 237 DISALLOW_COPY_AND_ASSIGN(VideoRendererBase);
239 }; 238 };
240 239
241 } // namespace media 240 } // namespace media
242 241
243 #endif // MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 242 #endif // MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
OLDNEW
« no previous file with comments | « media/filters/audio_renderer_impl_unittest.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698