Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10834234: [MIPS] Add DEBUG_BREAK() for MIPS architecture. (Closed)

Created:
8 years, 4 months ago by petarj
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Add DEBUG_BREAK() for MIPS architecture. Small change to add correct asm break instruction for MIPS architecture. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/debug/debugger_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
petarj
Here is a small change to add correct break instruction for MIPS architecture. PTAL. Thank ...
8 years, 4 months ago (2012-08-08 20:12:19 UTC) #1
brettw
lgtm
8 years, 4 months ago (2012-08-08 21:37:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/10834234/1
8 years, 4 months ago (2012-08-08 22:27:31 UTC) #3
commit-bot: I haz the power
Try job failure for 10834234-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 23:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/10834234/1
8 years, 4 months ago (2012-08-09 00:22:14 UTC) #5
commit-bot: I haz the power
Try job failure for 10834234-1 (retry) (retry) on linux_rel for step "nacl_integration". It's a second ...
8 years, 4 months ago (2012-08-09 02:18:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/10834234/1
8 years, 4 months ago (2012-08-09 11:25:10 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 14:02:15 UTC) #8
Change committed as 150789

Powered by Google App Engine
This is Rietveld 408576698