Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 10834232: Revert 150491 - refactor EnumerateDevices to make it a persistent request. (Closed)

Created:
8 years, 4 months ago by wjia(left Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 150491 - refactor EnumerateDevices to make it a persistent request. After the requester calls EnumerateDevices, it should expect new device list as initial response and whenever devices are changed. A new method StopEnumerateDevices is also added to allow the request to stop device enumeration. It also includes corresponding change in Pepper since EnumerateDevices contract is changed (http://codereview.chromium.org/10837064/). This patch keeps current Pepper API, while using the new API of EnumerateDevices from MediaStreamDispatcher. Pepper calls StopEnumerateDevices when it receives the first enumerated result. A new Pepper API will be created in a separate patch to make EnumerateDevices persistent. BUG=137799 Review URL: https://chromiumcodereview.appspot.com/10830063 BUG=141367 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -508 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 7 chunks +4 lines, -45 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 30 chunks +70 lines, -227 lines 0 comments Download
M content/common/media/media_stream_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/media/media_stream_options.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/media/media_stream_options.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 5 chunks +1 line, -48 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 13 chunks +16 lines, -122 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 7 chunks +17 lines, -20 lines 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_event_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_capture_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
wjia(left Chromium)
8 years, 4 months ago (2012-08-08 18:44:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698