Fixed race condition in test. Fixed spurious wait requests on shutdown.

Fixed race condition in test. Fixed spurious wait requests on shutdown.


NOTRY=True
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150769

[phoglund_chromium, 2012-08-08 15:24:16]

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
File chrome/test/data/webrtc/message_handling.js (right):

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
chrome/test/data/webrtc/message_handling.js:184: function
startHangingGet(server, ourId) {
We were sending messages after disconnecting earlier, and this prevents that.

http://codereview.chromium.org/10834229/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_call.py (right):

http://codereview.chromium.org/10834229/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_call.py:58: 
Tried to make naming consistent.

http://codereview.chromium.org/10834229/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_call.py:161: 'hangUp()',
tab_index=from_tab_with_index))
This is another case where the test would fail if WebRTC responded too slowly,
so this should fix that.

[Nirnimesh, 2012-08-08 18:41:04]

LGTM

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
File chrome/test/data/webrtc/message_handling.js (right):

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
chrome/test/data/webrtc/message_handling.js:134: function is_disconnected() {
js function names should not have underscores. Use camelCase

[phoglund_chromium, 2012-08-09 09:00:24]

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
File chrome/test/data/webrtc/message_handling.js (right):

http://codereview.chromium.org/10834229/diff/1/chrome/test/data/webrtc/messag...
chrome/test/data/webrtc/message_handling.js:134: function is_disconnected() {
On 2012/08/08 18:41:04, Nirnimesh wrote:
> js function names should not have underscores. Use camelCase

Done.

[commit-bot: I haz the power, 2012-08-09 09:01:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/10834229/1003

[commit-bot: I haz the power, 2012-08-09 09:01:21]

Change committed as 150769