contacts: Only download contacts from "My Contacts" group.

contacts: Only download contacts from "My Contacts" group.

The contacts GData code was previously fetching the default
feed, which includes "Other Contacts" suggested by Gmail
(i.e. everyone you've ever emailed).

This change makes GDataContactsService first fetch the list
of contact groups so it can find the ID of the user-curated
"My Contacts" group, and then use it when requesting the
contacts themselves.

BUG=128805
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150575

[satorux1, 2012-08-08 13:37:16]

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_contacts_service.cc (right):

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:330: std::string
system_group_id;
What are the difference between the two IDs? Examples would be helpful here.

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:337: std::string
GetGroupIdForSystemGroup(const std::string& system_group_id) {
Is this used?

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:490:
my_contacts_group_id_,
Since we know that this will always be "Contacts", I guess we don't have to
fetch the groups feed, which is adding complexity. I'd not to fetch the groups
feed, if unnecessary.

[Daniel Erat, 2012-08-08 14:30:49]

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_contacts_service.cc (right):

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:330: std::string
system_group_id;
On 2012/08/08 13:37:16, satorux1 wrote:
> What are the difference between the two IDs? Examples would be helpful here.

Described just below in GetGroupIdForSystemGroup()'s comment, which I'll move up
here.

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:337: std::string
GetGroupIdForSystemGroup(const std::string& system_group_id) {
On 2012/08/08 13:37:16, satorux1 wrote:
> Is this used?

Whoops, I added this but somehow didn't call it later (this change went through
a refactoring before I uploaded it).  Fixed; thanks for catching this.

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:490:
my_contacts_group_id_,
On 2012/08/08 13:37:16, satorux1 wrote:
> Since we know that this will always be "Contacts", I guess we don't have to
> fetch the groups feed, which is adding complexity. I'd not to fetch the groups
> feed, if unnecessary.

"Contacts" is the "My Contacts" group's system group ID, but we need its regular
group ID, which looks like a URL under "http://www.google.com/m8/feeds/groups".

I wish that there were a way to get only members of the "My Contacts" group
without looking up the group's ID first, but there doesn't appear to be from
e.g.
http://code.google.com/a/google.com/p/apps-api-issues/issues/detail?id=675#c89.

I also wish that the API used better names here. :-(

[satorux1, 2012-08-08 14:58:10]

LGTM

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_contacts_service.cc (right):

http://codereview.chromium.org/10834220/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:490:
my_contacts_group_id_,
On 2012/08/08 14:30:50, Daniel Erat wrote:
> On 2012/08/08 13:37:16, satorux1 wrote:
> > Since we know that this will always be "Contacts", I guess we don't have to
> > fetch the groups feed, which is adding complexity. I'd not to fetch the
groups
> > feed, if unnecessary.
> 
> "Contacts" is the "My Contacts" group's system group ID, but we need its
regular
> group ID, which looks like a URL under
"http://www.google.com/m8/feeds/groups".
> 
> I wish that there were a way to get only members of the "My Contacts" group
> without looking up the group's ID first, but there doesn't appear to be from
> e.g.
>
http://code.google.com/a/google.com/p/apps-api-issues/issues/detail?id=675#c89.
> 
> I also wish that the API used better names here. :-(

Ah I see. That explains.

[commit-bot: I haz the power, 2012-08-08 15:32:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10834220/9001

[commit-bot: I haz the power, 2012-08-08 17:11:52]

Change committed as 150575