Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10834217: Fix issue with some locales simetimes getting the wrong page size. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix issue with some locales simetimes getting the wrong page size. We use ulocdata_getPaperSize to get the preferred paper size for a region. The error handling for the call assumed that a value other than U_ZERO_ERROR was an error. This is incorrect. The function sometimes returns a warning (negative value). When that happens, the error handling code defaulted to 8.5x11 pages. This CL changes the error handling to no longer treat a warning as an error. BUG=140821 TEST=Set display language to English(UK). Print a web page and choose to save as PDF. Verify that the saved PDF is A4. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M printing/printing_context_no_system_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Albert Bodenhamer
Vitaly, can you take a look at this?
8 years, 4 months ago (2012-08-07 21:57:12 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
8 years, 4 months ago (2012-08-07 21:59:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10834217/1
8 years, 4 months ago (2012-08-07 21:59:56 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 23:44:32 UTC) #4
Change committed as 150447

Powered by Google App Engine
This is Rietveld 408576698