Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 10834210: roll skia to 4991 (Closed)

Created:
8 years, 4 months ago by reed1
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, skia-dev_google.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
control https://chromiumcodereview.appspot.com/10823204
8 years, 4 months ago (2012-08-07 17:37:46 UTC) #1
tomhudson
Missing gyp change? SkOrderedWriteBuffer.obj : error LNK2019: unresolved external symbol "public: virtual __thiscall SkFlattenableWriteBuffer::~SkFlattenableWriteBuffer(void)" (??1SkFlattenableWriteBuffer@@UAE@XZ) ...
8 years, 4 months ago (2012-08-07 19:03:04 UTC) #2
reed1
no failures due to this CL PTAL
8 years, 4 months ago (2012-08-07 22:04:02 UTC) #3
tomhudson
8 years, 4 months ago (2012-08-07 22:14:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698