Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10834207: aura: Long launcher tooltips should elide at end. (Closed)

Created:
8 years, 4 months ago by varunjain
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Long launcher tooltips should elide at end. BUG=133292 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150704

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Total comments: 2

Patch Set 3 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M ash/launcher/launcher_tooltip_manager.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/label.h View 1 3 chunks +11 lines, -5 lines 0 comments Download
M ui/views/controls/label.cc View 1 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
varunjain
8 years, 4 months ago (2012-08-07 16:06:43 UTC) #1
sky
https://chromiumcodereview.appspot.com/10834207/diff/1/ui/views/controls/label.h File ui/views/controls/label.h (right): https://chromiumcodereview.appspot.com/10834207/diff/1/ui/views/controls/label.h#newcode270 ui/views/controls/label.h:270: bool elide_in_middle_; Can we use ElideBehavior directly instead of ...
8 years, 4 months ago (2012-08-07 19:41:59 UTC) #2
varunjain
https://chromiumcodereview.appspot.com/10834207/diff/1/ui/views/controls/label.h File ui/views/controls/label.h (right): https://chromiumcodereview.appspot.com/10834207/diff/1/ui/views/controls/label.h#newcode270 ui/views/controls/label.h:270: bool elide_in_middle_; On 2012/08/07 19:41:59, sky wrote: > Can ...
8 years, 4 months ago (2012-08-07 20:24:10 UTC) #3
sky
LGTM https://chromiumcodereview.appspot.com/10834207/diff/4001/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc File chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc (right): https://chromiumcodereview.appspot.com/10834207/diff/4001/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc#newcode90 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:90: elide_in_middle? views::Label::ELIDE_IN_MIDDLE : views::Label::NO_ELIDE); nit: space after '?' ...
8 years, 4 months ago (2012-08-08 20:59:19 UTC) #4
varunjain
https://chromiumcodereview.appspot.com/10834207/diff/4001/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc File chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc (right): https://chromiumcodereview.appspot.com/10834207/diff/4001/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc#newcode90 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:90: elide_in_middle? views::Label::ELIDE_IN_MIDDLE : views::Label::NO_ELIDE); On 2012/08/08 20:59:19, sky wrote: ...
8 years, 4 months ago (2012-08-08 21:14:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10834207/5006
8 years, 4 months ago (2012-08-08 21:14:46 UTC) #6
commit-bot: I haz the power
Try job failure for 10834207-5006 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 22:34:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10834207/5006
8 years, 4 months ago (2012-08-08 22:40:16 UTC) #8
commit-bot: I haz the power
Try job failure for 10834207-5006 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 23:20:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10834207/5006
8 years, 4 months ago (2012-08-09 02:05:50 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 03:23:15 UTC) #11 
Change committed as 150704

Powered by Google App Engine
This is Rietveld 408576698