Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 10834201: Revert 150232 (speculative, probably broke (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
aruslan
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 150232 (speculative, probably broke LauncherFaviconLoaderBrowsertest.ChangeLauncherIcons on cros bots) - Update favicon URLs on FinishLoad for main frame Previously it was done on didStopLoading for _any_ frame. That causes a stream of spurious favicon URL updates for every <iframe>. This is now moved to on didFinishLoad and get triggered only for the main frame. This ensures that icon loads always get initiated after all of the other page resources have been fetched. Note that DidFinishDocumentLoad runs potentially before all subresources have been fetched, which means that the icon requests may compete with subresources for network bandwidth. didFinishLoad is the closest place to where IconController does it, and we already have icons at this point. BUG=131567 Review URL: https://chromiumcodereview.appspot.com/10831163 TBR=aruslan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M chrome/renderer/chrome_render_view_observer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 3 chunks +20 lines, -26 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 4 months ago (2012-08-07 04:50:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698