Issue 10834194: Change email to be OPT-IN on Chrome and OPT-OUT on cros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834194: Change email to be OPT-IN on Chrome and OPT-OUT on cros. (Closed)

Created:
8 years, 4 months ago by rkc

Modified:
8 years, 4 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change email to be OPT-IN on Chrome and OPT-OUT on cros. This CL changes the email box to be checked for chrome os and unchecked for Chrome. R=jhawkins@chromium.org BUG=140946 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150226

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -1 line)			Patch
M	chrome/browser/resources/feedback.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/feedback.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/feedback_ui.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10834194/1

8 years, 4 months ago (2012-08-06 22:54:25 UTC) #3

commit-bot: I haz the power

Try job failure for 10834194-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-06 23:27:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10834194/1

8 years, 4 months ago (2012-08-06 23:46:41 UTC) #5

Change committed as 150226