new implementation of default apps

chrome/browser/extensions/extension_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service_unittest.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 12 matching lines @@
 #include "base/stl_util.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/app_sync_data.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/default_apps.h"
 #include "chrome/browser/extensions/extension_creator.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_error_ui.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_sorting.h"
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/extensions/extension_sync_data.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/external_pref_loader.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
@@ skipping 3671 matching lines @@
   InitializeEmptyExtensionService();
 
   // Now add providers. Extension system takes ownership of the objects.
   MockExtensionProvider* pref_provider =
       new MockExtensionProvider(service_, Extension::EXTERNAL_PREF);
 
   AddMockExternalProvider(pref_provider);
   TestExternalProvider(pref_provider, Extension::EXTERNAL_PREF);
 }
 
+TEST_F(ExtensionServiceTest, DefaultAppsInstall) {

[Mihai Parparita -not on Chrome, 2012/08/16 00:58:24]

Can you also add a test for the migration case where the chrome version changes
(the bug you fixed in this most recent patch set)?

+  scoped_ptr<TestingProfile> profile(new TestingProfile());
+
+  // The default apps should be installed if kDefaultAppsInstallState
+  // is unknown.
+  EXPECT_TRUE(default_apps::ShouldInstallInProfile(profile.get()));
+  int state = profile->GetPrefs()->GetInteger(prefs::kDefaultAppsInstallState);
+  EXPECT_TRUE(state == default_apps::kAlreadyInstalledDefaultApps);
+
+  // The default apps should only be installed once.
+  EXPECT_FALSE(default_apps::ShouldInstallInProfile(profile.get()));
+  state = profile->GetPrefs()->GetInteger(prefs::kDefaultAppsInstallState);
+  EXPECT_TRUE(state == default_apps::kAlreadyInstalledDefaultApps);
+
+  // The default apps should not be installed if the state is
+  // kNeverProvideDefaultApps
+  profile->GetPrefs()->SetInteger(prefs::kDefaultAppsInstallState,
+      default_apps::kNeverInstallDefaultApps);
+  EXPECT_FALSE(default_apps::ShouldInstallInProfile(profile.get()));
+  state = profile->GetPrefs()->GetInteger(prefs::kDefaultAppsInstallState);
+  EXPECT_TRUE(state == default_apps::kNeverInstallDefaultApps);
+
+  // The old default apps with kAlwaysInstallDefaultAppss should be migrated.
+  profile->GetPrefs()->SetInteger(prefs::kDefaultAppsInstallState,
+      default_apps::kProvideLegacyDefaultApps);
+  EXPECT_TRUE(default_apps::ShouldInstallInProfile(profile.get()));
+  state = profile->GetPrefs()->GetInteger(prefs::kDefaultAppsInstallState);
+  EXPECT_TRUE(state == default_apps::kAlreadyInstalledDefaultApps);
+}
+
 TEST_F(ExtensionServiceTest, ExternalInstallPrefUpdateUrl) {
   // This should all work, even when normal extension installation is disabled.
   InitializeEmptyExtensionService();
   set_extensions_enabled(false);
 
   // TODO(skerner): The mock provider is not a good model of a provider
   // that works with update URLs, because it adds file and version info.
   // Extend the mock to work with update URLs.  This test checks the
   // behavior that is common to all external extension visitors.  The
   // browser test ExtensionManagementTest.ExternalUrlUpdate tests that
@@ skipping 1512 matching lines @@
   // This should NOT trigger an alert.
   provider->UpdateOrAddExtension(hosted_app, "1.0.0.0",
                                  data_dir_.AppendASCII("hosted_app.crx"));
 
   service_->CheckForExternalUpdates();
   loop_.RunAllPending();
 
   ASSERT_TRUE(service_->PopulateExtensionErrorUI(extension_error_ui.get()));
   ASSERT_EQ(1u, extension_error_ui->get_external_extension_ids()->size());
 }