new implementation of default apps

chrome/browser/extensions/external_provider_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_provider_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 376 matching lines @@
   provider_list->push_back(
       linked_ptr<ExternalProviderInterface>(
           new ExternalProviderImpl(
               service,
               new ExternalPolicyLoader(profile),
               Extension::INVALID,
               Extension::EXTERNAL_POLICY_DOWNLOAD,
               Extension::NO_FLAGS)));
 
 #if !defined(OS_CHROMEOS)
+  // The default apps are installed as INTERNAL but use the external

[Mihai Parparita -not on Chrome, 2012/08/08 00:22:43]

This is clever, since it means that you don't have to reinvent a mechanism for
installing a list of extensions. However, I can see it being a bit confusing
(since it uses the "external" name).

Aaron, does this seem OK to you?

[Aaron Boodman, 2012/08/08 22:23:29]

It seems reasonable to me that providers can specify what location they want to
be installed as, and that they only participate in the rest of the protocol if
they pick one of external_*.

The naming is a bit confusing due to legacy... maybe these are really just
ExtensionProviders, or ExtensionInstallSources, or something. It would be nice
to rename it so that its behavior is better described. But that could be a
separate CL.

[Gaurav, 2012/08/10 23:06:55]

It may require more re-factoring and isolation. The kind at some places assumes
that all extensions provided are external and uninstalls them if they are not
provided anymore.
Will do in a followup CL.
On 2012/08/08 22:23:29, Aaron Boodman wrote:

+  // extension installer codeflow.
   provider_list->push_back(
       linked_ptr<ExternalProviderInterface>(
           new default_apps::Provider(
               profile,
               service,
               new ExternalPrefLoader(chrome::DIR_DEFAULT_APPS,
                                      ExternalPrefLoader::NONE),
-              Extension::EXTERNAL_PREF,
+              Extension::INTERNAL,
               Extension::INVALID,
               Extension::FROM_WEBSTORE)));
 #endif
 
 #if defined(OS_CHROMEOS)
   policy::BrowserPolicyConnector* connector =
       g_browser_process->browser_policy_connector();
   if (is_chromeos_demo_session && connector->GetAppPackUpdater()) {
     provider_list->push_back(
         linked_ptr<ExternalProviderInterface>(
           new ExternalProviderImpl(
               service,
               connector->GetAppPackUpdater()->CreateExternalLoader(),
               Extension::EXTERNAL_PREF,
               Extension::INVALID,
               Extension::NO_FLAGS)));
   }
 #endif
 }
 
 }  // namespace extensions