new implementation of default apps

chrome/browser/extensions/default_apps.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_

[Aaron Boodman, 2012/08/08 22:23:29]

Nit: Since this is not really apps-specific, it should be called
default_extensions or default_items.

 #define CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_
 
 #include "base/basictypes.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
 
 class PrefService;
 class Profile;
 
 namespace extensions {
 class Extension;
 }
 
 // Functions and types related to installing default apps.
 namespace default_apps {
 
 // These enum values are persisted in the user preferences, so they should not
 // be changed.
 enum InstallState {
   kUnknown,
+  kNeverProvideDefaultApps,

[Aaron Boodman, 2012/08/08 22:23:29]

Usually when enums have a warning like this, the order should not be changed
(because the thing persisted is the integer value).

[Gaurav, 2012/08/10 23:06:55]

Ya I missed it. Fixed it now.
On 2012/08/08 22:23:29, Aaron Boodman wrote:

+  // Now unused, leave it for backward compatibility.
   kAlwaysProvideDefaultApps,
-  kNeverProvideDefaultApps
+  kAlreadyInstalledDefaultApps
 };
 
 // Register preference properties used by default apps to maintain
 // install state.
 void RegisterUserPrefs(PrefService* prefs);
 
 
 // A specialization of the ExternalProviderImpl that conditionally installs apps
 // from the chrome::DIR_DEFAULT_APPS location based on a preference in the
 // profile.
@@ skipping 11 matching lines @@
 
  private:
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(Provider);
 };
 
 }  // namespace default_apps
 
 #endif  // CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_