Issue 10834188: [Web Intents] Small refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834188: [Web Intents] Small refactor (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16

Modified:
8 years, 4 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Web Intents] Small refactor Hoisted out common code while preparing for bigger changes for "waiting" dialog R=gbillock@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150269

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -34 lines)			Patch
	M	chrome/browser/ui/intents/web_intent_picker_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		2 chunks	+24 lines, -34 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10834188/1

8 years, 4 months ago (2012-08-06 22:16:10 UTC) #3

commit-bot: I haz the power

Try job failure for 10834188-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-06 22:54:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10834188/1

8 years, 4 months ago (2012-08-07 02:13:58 UTC) #5

Change committed as 150269