Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10834187: Changing strings for maximize bubble menu (Closed)

Created:
8 years, 4 months ago by Mr4D (OOO till 08-26)
Modified:
8 years, 4 months ago
Reviewers:
Daniel Erat, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Changing strings for maximize bubble menu Last minute string changes to make them fit in various languages. BUG=140834 TEST=Visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/ash_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mr4D (OOO till 08-26)
Few text lines have changed needed before branching
8 years, 4 months ago (2012-08-06 20:07:06 UTC) #1
jennyz
lgtm
8 years, 4 months ago (2012-08-06 20:07:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10834187/1
8 years, 4 months ago (2012-08-06 20:08:10 UTC) #3
commit-bot: I haz the power
Presubmit check for 10834187-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-06 20:08:11 UTC) #4
Mr4D (OOO till 08-26)
Please do an Owners review! Many thanks!
8 years, 4 months ago (2012-08-06 20:15:19 UTC) #5
Daniel Erat
lgtm
8 years, 4 months ago (2012-08-06 20:16:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10834187/1
8 years, 4 months ago (2012-08-06 20:16:30 UTC) #7
commit-bot: I haz the power
Try job failure for 10834187-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 20:52:34 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 21:20:29 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698