A unit test that creates a situation that crashed (bug 130306)

ash/ash.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
   },
 
@@ skipping 365 matching lines @@
         '../chrome/chrome_resources.gyp:packed_resources',
         '../content/content.gyp:content_browser',
         '../content/content.gyp:test_support_content',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../skia/skia.gyp:skia',
         '../testing/gtest.gyp:gtest',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../ui/aura/aura.gyp:aura',
         '../ui/aura/aura.gyp:test_support_aura',
+        '../ui/app_list/app_list.gyp:app_list',
         '../ui/compositor/compositor.gyp:compositor',
         '../ui/compositor/compositor.gyp:compositor_test_support',
         '../ui/ui.gyp:ui',
         '../ui/ui.gyp:ui_resources',
         '../ui/ui.gyp:ui_test_support',
         '../ui/views/views.gyp:views',
+        '../ui/views/views.gyp:views_examples_lib',

[sky, 2012/08/06 21:21:22]

Why are you adding this dependency?

[Harry McCleave, 2012/08/07 18:17:23]

as discussed. (window_type_launcher can reference examples)

         '../ui/views/views.gyp:test_support_views',
         'ash',
       ],
       'sources': [
         '../ui/views/test/test_views_delegate.cc',
         '../ui/views/test/test_views_delegate.h',
+        '../ui/app_list/app_list_item_model.cc',

[sky, 2012/08/06 21:21:22]

Why are you explicitly adding this? It should be covered by adding a dependency
on app_list above.

[Harry McCleave, 2012/08/07 18:17:23]

Done.

         'accelerators/accelerator_controller_unittest.cc',
         'accelerators/accelerator_filter_unittest.cc',
         'accelerators/accelerator_table_unittest.cc',
         'accelerators/nested_dispatcher_controller_unittest.cc',
         'dip_unittest.cc',
         'display/display_controller_unittest.cc',
         'display/multi_display_manager_unittest.cc',
         'drag_drop/drag_drop_controller_unittest.cc',
         'extended_desktop_unittest.cc',
         'focus_cycler_unittest.cc',
         'launcher/launcher_context_menu_unittest.cc',
         'launcher/launcher_model_unittest.cc',
         'launcher/launcher_navigator_unittest.cc',
         'launcher/launcher_tooltip_manager_unittest.cc',
         'launcher/launcher_unittest.cc',
         'launcher/launcher_view_unittest.cc',
         'root_window_controller_unittest.cc',
         'screen_ash_unittest.cc',
         'screensaver/screensaver_view_unittest.cc',
         'shell_unittest.cc',
+        'shell/app_list.cc',
+        'shell/bubble.cc',
+        'shell/launcher_delegate_impl.cc',
+        'shell/lock_view.cc',
+        'shell/panel_window.cc',
+        'shell/shell_delegate_impl.cc',
+        'shell/toplevel_window.cc',
+        'shell/widgets.cc',
+        'shell/window_type_launcher.cc',
+        'shell/window_watcher.cc',
         'system/tray/system_tray_unittest.cc',
         'system/web_notification/web_notification_tray_unittest.cc',
         'test/ash_test_base.cc',
         'test/ash_test_base.h',
         'test/ash_unittests.cc',
         'test/capture_tracking_view.cc',
         'test/capture_tracking_view.h',
         'test/launcher_view_test_api.cc',
         'test/launcher_view_test_api.h',
         'test/test_activation_delegate.cc',
@@ skipping 181 matching lines @@
             'shell/cocoa/app-Info.plist',
           ],
           'xcode_settings': {
             'INFOPLIST_FILE': 'shell/cocoa/app-Info.plist',
           },
         }],
       ],
     },
   ],
 }