Copy the !details.is_in_page restriction from TabHelper to PageActionController::DidNavigateMainFra…

Copy the !details.is_in_page restriction from TabHelper to PageActionController::DidNavigateMainFrame

Oops, r145054 forgot to do this.

BUG=139410
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150268

[not at google - send to devlin, 2012-08-06 22:09:19]

https://chromiumcodereview.appspot.com/10834184/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/page_action_controller.cc (right):

https://chromiumcodereview.appspot.com/10834184/diff/1/chrome/browser/extensi...
chrome/browser/extensions/page_action_controller.cc:93: const
std::vector<ExtensionAction*> current_actions = GetCurrentActions();
remind me why we clear page actions on navigation?

[Jeffrey Yasskin, 2012-08-06 22:24:25]

https://chromiumcodereview.appspot.com/10834184/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/page_action_controller.cc (right):

https://chromiumcodereview.appspot.com/10834184/diff/1/chrome/browser/extensi...
chrome/browser/extensions/page_action_controller.cc:93: const
std::vector<ExtensionAction*> current_actions = GetCurrentActions();
On 2012/08/06 22:09:19, kalman wrote:
> remind me why we clear page actions on navigation?

I believe a page action is a statement that an extension has something it can do
to the current page if the user clicks. When there's a new page, the page
action's statement might no longer be valid.

In any case, this behavior dates to the original implementation of page actions,
in r15415.

(Hah. r24654 fixed this exact bug, 3 years ago. :-(

[not at google - send to devlin, 2012-08-06 22:27:14]

Ah I didn't realise we did that. Cool, lgtm.

We could add a test for this btw, script badges had a similar problem and the
hash navigation is tested.

[commit-bot: I haz the power, 2012-08-06 22:28:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10834184/1

[Jeffrey Yasskin, 2012-08-06 22:31:02]

On 2012/08/06 22:27:14, kalman wrote:
> Ah I didn't realise we did that. Cool, lgtm.
> 
> We could add a test for this btw, script badges had a similar problem and the
> hash navigation is tested.

Yep. I assume the only way to test this is a browser-test? Where's the script
badge test?

[not at google - send to devlin, 2012-08-06 22:33:27]

nope, script_badge_unittest does it.

[not at google - send to devlin, 2012-08-06 22:36:07]

script_badge_controller_unittest.cc rather (line 170 in my checkout)

[commit-bot: I haz the power, 2012-08-06 23:04:16]

Try job failure for 10834184-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-07 01:58:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10834184/1

[commit-bot: I haz the power, 2012-08-07 04:08:30]

Change committed as 150268