Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10834174: intents: Constantify some getter accessors. (Closed)

Created:
8 years, 4 months ago by tfarina
Modified:
8 years, 4 months ago
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org
Visibility:
Public.

Description

intents: Constantify some getter accessors. R=gbillock@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150965

Patch Set 1 #

Total comments: 2

Patch Set 2 : mimetype -> type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.h View 1 5 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
8 years, 4 months ago (2012-08-06 00:20:33 UTC) #1
Greg Billock
http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h File chrome/browser/ui/intents/web_intent_picker_model.h (right): http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h#newcode77 chrome/browser/ui/intents/web_intent_picker_model.h:77: const string16& mimetype() const { return mimetype_; } Can ...
8 years, 4 months ago (2012-08-06 18:01:58 UTC) #2
tfarina
http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h File chrome/browser/ui/intents/web_intent_picker_model.h (right): http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h#newcode77 chrome/browser/ui/intents/web_intent_picker_model.h:77: const string16& mimetype() const { return mimetype_; } On ...
8 years, 4 months ago (2012-08-07 01:08:56 UTC) #3
Greg Billock
On 2012/08/07 01:08:56, tfarina wrote: > http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h > File chrome/browser/ui/intents/web_intent_picker_model.h (right): > > http://codereview.chromium.org/10834174/diff/1/chrome/browser/ui/intents/web_intent_picker_model.h#newcode77 > ...
8 years, 4 months ago (2012-08-07 01:19:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10834174/6
8 years, 4 months ago (2012-08-09 12:09:26 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 12:09:28 UTC) #6 
Failed to apply patch for
chrome/browser/ui/intents/web_intent_picker_controller.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/intents/web_intent_picker_controller.cc
Hunk #3 FAILED at 422.
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/ui/intents/web_intent_picker_controller.cc.rej

Powered by Google App Engine
This is Rietveld 408576698