Issue 10834173: Retry "Add an interface for PNaCl to check if the session is incognito..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834173: Retry "Add an interface for PNaCl to check if the session is incognito..." (Closed)

Created:
8 years, 4 months ago by jvoung (off chromium)

Modified:
8 years, 4 months ago

Reviewers:
sehr (please use chromium), Derek Schuff

CC:
chromium-reviews, piman+watch_chromium.org, ihf+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Retry "Add an interface for PNaCl to check if the session is incognito..." (previously 149749). Again, we use the interface to use the cache when available, or to load from a temporary file in incognito, when the cache is not available. Differences from previous try: * double-fd-close bug. * compiler warnings that show up in scons build. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150093

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -124 lines)			Patch
M	chrome/renderer/pepper/ppb_nacl_private_impl.cc	View		4 chunks	+8 lines, -1 line	0 comments	Download
M	ppapi/api/private/finish_writing_these/ppb_nacl_private.idl	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/local_temp_file.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h	View		5 chunks	+45 lines, -30 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1 2	13 chunks	+169 lines, -69 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/temporary_file.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/temporary_file.cc	View	1	1 chunk	+19 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

lgtm