Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: webkit/fileapi/file_system_file_util_proxy.cc

Issue 10834167: Create ShareableFileReference on IO thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: adding unknown policy for DCHECK Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/file_system_file_util_proxy.h ('k') | webkit/fileapi/file_util_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_file_util_proxy.cc
diff --git a/webkit/fileapi/file_system_file_util_proxy.cc b/webkit/fileapi/file_system_file_util_proxy.cc
index a566fc70d51fcafd7e80e9897ae4cbf4f6f906de..86cdbf45d8faae2a57a7811fa045e525225c5eba 100644
--- a/webkit/fileapi/file_system_file_util_proxy.cc
+++ b/webkit/fileapi/file_system_file_util_proxy.cc
@@ -47,7 +47,9 @@ class EnsureFileExistsHelper {
class GetFileInfoHelper {
public:
- GetFileInfoHelper() : error_(base::PLATFORM_FILE_OK) {}
+ GetFileInfoHelper()
+ : error_(base::PLATFORM_FILE_OK),
+ snapshot_policy_(FileSystemFileUtil::kSnapshotFileUnknown) {}
void GetFileInfo(FileSystemFileUtil* file_util,
FileSystemOperationContext* context,
@@ -58,8 +60,8 @@ class GetFileInfoHelper {
void CreateSnapshotFile(FileSystemFileUtil* file_util,
FileSystemOperationContext* context,
const FileSystemURL& url) {
- file_ref_ = file_util->CreateSnapshotFile(
- context, url, &error_, &file_info_, &platform_path_);
+ error_ = file_util->CreateSnapshotFile(
+ context, url, &file_info_, &platform_path_, &snapshot_policy_);
}
void ReplyFileInfo(const Proxy::GetFileInfoCallback& callback) {
@@ -68,15 +70,16 @@ class GetFileInfoHelper {
}
void ReplySnapshotFile(const Proxy::SnapshotFileCallback& callback) {
+ DCHECK(snapshot_policy_ != FileSystemFileUtil::kSnapshotFileUnknown);
if (!callback.is_null())
- callback.Run(error_, file_info_, platform_path_, file_ref_);
+ callback.Run(error_, file_info_, platform_path_, snapshot_policy_);
}
private:
base::PlatformFileError error_;
base::PlatformFileInfo file_info_;
FilePath platform_path_;
- scoped_refptr<webkit_blob::ShareableFileReference> file_ref_;
+ FileSystemFileUtil::SnapshotFilePolicy snapshot_policy_;
DISALLOW_COPY_AND_ASSIGN(GetFileInfoHelper);
};
« no previous file with comments | « webkit/fileapi/file_system_file_util_proxy.h ('k') | webkit/fileapi/file_util_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698