Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10834167: Create ShareableFileReference on IO thread (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
Reviewers:
michaeln, kmadhusu, tzik
CC:
chromium-reviews, feature-media-reviews_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Create ShareableFileReference on IO thread * ShareableFileReference is not thread-safe, we should make sure we only handle it on IO thread * FileUtil implementation no longer needs to directly handle ShareableFileReference BUG=140508 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149992

Patch Set 1 : #

Patch Set 2 : media file util fix #

Patch Set 3 : adding unknown policy for DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -85 lines) Patch
M webkit/fileapi/file_system_file_util.h View 1 2 2 chunks +22 lines, -12 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.h View 2 chunks +8 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.cc View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M webkit/fileapi/file_util_helper.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 2 chunks +10 lines, -1 line 0 comments Download
M webkit/fileapi/local_file_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/fileapi/local_file_util.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M webkit/fileapi/media/device_media_file_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/fileapi/media/device_media_file_util.cc View 1 3 chunks +20 lines, -25 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
PTL thanks!
8 years, 4 months ago (2012-08-03 23:00:07 UTC) #1
tzik
On 2012/08/03 23:00:07, kinuko wrote: > PTL thanks! Looks good. Could you add NonThreadSafe to ...
8 years, 4 months ago (2012-08-03 23:12:32 UTC) #2
kinuko
On 2012/08/03 23:12:32, tzik wrote: > On 2012/08/03 23:00:07, kinuko wrote: > > PTL thanks! ...
8 years, 4 months ago (2012-08-03 23:15:04 UTC) #3
michaeln
LGTM
8 years, 4 months ago (2012-08-03 23:15:57 UTC) #4
kinuko
+kmadhusu Kausalya, can you take a quick look at the changes in device_media_file_util.cc?
8 years, 4 months ago (2012-08-03 23:17:17 UTC) #5
tzik
lgtm
8 years, 4 months ago (2012-08-03 23:17:17 UTC) #6
kmadhusu
lgtm
8 years, 4 months ago (2012-08-03 23:41:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10834167/7003
8 years, 4 months ago (2012-08-03 23:51:28 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 01:23:57 UTC) #9
Change committed as 149992

Powered by Google App Engine
This is Rietveld 408576698