Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 10834165: Don't reuse a GpuProcessHost that failed to send a message (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Don't reuse a GpuProcessHost that failed to send a message When the GPU process dies/gets killed, the Send() can fail (e.g. EPIPE), triggering lost context recreation, before OnChannelError gets called (happening when we return to the message loop) which ends up deleting the GpuProcessHost. So, in the mean time, make sure we don't try to reuse that GpuProcessHost to recreate a channel. BUG=129067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149984

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add parens to silence clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
8 years, 4 months ago (2012-08-03 21:53:45 UTC) #1
apatrick_chromium
lgtm
8 years, 4 months ago (2012-08-03 22:00:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10834165/7001
8 years, 4 months ago (2012-08-03 22:04:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10834165/6003
8 years, 4 months ago (2012-08-03 22:26:40 UTC) #4
commit-bot: I haz the power
Try job failure for 10834165-6003 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 22:47:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10834165/6003
8 years, 4 months ago (2012-08-03 23:00:28 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 00:26:20 UTC) #7
Change committed as 149984

Powered by Google App Engine
This is Rietveld 408576698