Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10834161: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -87 lines) Patch
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 38 chunks +39 lines, -38 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 21 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm View 7 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rpetterson
pinkerton - ui/cocoa/applescript mrossetti - ui/cocoa/bookmarks
8 years, 4 months ago (2012-08-03 20:26:48 UTC) #1
pink (ping after 24hrs)
lgtm
8 years, 4 months ago (2012-08-06 12:48:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10834161/1
8 years, 4 months ago (2012-08-06 18:06:47 UTC) #3
commit-bot: I haz the power
Try job failure for 10834161-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 18:23:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10834161/1
8 years, 4 months ago (2012-08-06 18:49:18 UTC) #5
commit-bot: I haz the power
Change committed as 150140
8 years, 4 months ago (2012-08-06 20:24:18 UTC) #6
mrossetti
8 years, 4 months ago (2012-08-07 17:18:41 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698