Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: media/audio/audio_manager_base.cc

Issue 10834159: Put browser side mixing back behind a flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 6acbf2038f53ca0f3655e338cfe80764851363a1..444a41532e9f1c819185d49ff540d25c0e9ddd79 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -142,15 +142,13 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStreamProxy(
if (!dispatcher) {
base::TimeDelta close_delay =
base::TimeDelta::FromSeconds(kStreamCloseDelaySeconds);
-// TODO(dalecurtis): Temporarily disable the mixer for non-Windows/Mac platforms
-// until a fix for http://crbug.com/138098 can be found.
-#if defined(OS_WIN) || defined(OS_MACOSX)
const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
- if (!cmd_line->HasSwitch(switches::kDisableAudioMixer)) {
+ // TODO(dalecurtis): Browser side mixing has a couple issues that must be
+ // fixed before it can be turned on by default: http://crbug.com/138098 and
+ // http://crbug.com/140247
+ if (cmd_line->HasSwitch(switches::kEnableAudioMixer)) {
dispatcher = new AudioOutputMixer(this, params, close_delay);
- } else
-#endif
- {
+ } else {
dispatcher = new AudioOutputDispatcherImpl(this, params, close_delay);
}
}
« no previous file with comments | « no previous file | media/base/media_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698