Issue 10834151: Create OWNERS file for chrome/renderer/resources/extensions

Issue 10834151: Create OWNERS file for chrome/renderer/resources/extensions (Closed)

Created:
8 years, 4 months ago by battre

Modified:
8 years, 4 months ago

Reviewers:
Aaron Boodman, Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create OWNERS file for chrome/renderer/resources/extensions Creating OWNERS file for extensions team so that this does not need to be covered by chrome/OWNERS. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150079

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed aa's comment #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -19 lines)			Patch
M	chrome/browser/chromeos/extensions/OWNERS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/OWNERS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/OWNERS	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/OWNERS	View	1	1 chunk	+4 lines, -14 lines	2 comments	Download
M	chrome/renderer/extensions/OWNERS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	chrome/renderer/resources/extensions/OWNERS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/10834151/diff/1/chrome/renderer/resources/extensions/OWNERS File chrome/renderer/resources/extensions/OWNERS (right): http://codereview.chromium.org/10834151/diff/1/chrome/renderer/resources/extensions/OWNERS#newcode8 chrome/renderer/resources/extensions/OWNERS:8: kathyw@chromium.org This one isn't correct (and anywhere else ...

8 years, 4 months ago (2012-08-03 11:59:28 UTC) #2

battre

please take another look. https://chromiumcodereview.appspot.com/10834151/diff/5001/chrome/common/extensions/api/OWNERS File chrome/common/extensions/api/OWNERS (left): https://chromiumcodereview.appspot.com/10834151/diff/5001/chrome/common/extensions/api/OWNERS#oldcode4 chrome/common/extensions/api/OWNERS:4: bolms@chromium.org Ben is not listed ...

8 years, 4 months ago (2012-08-03 12:13:26 UTC) #3

Aaron Boodman

lgtm https://chromiumcodereview.appspot.com/10834151/diff/5001/chrome/common/extensions/api/OWNERS File chrome/common/extensions/api/OWNERS (left): https://chromiumcodereview.appspot.com/10834151/diff/5001/chrome/common/extensions/api/OWNERS#oldcode4 chrome/common/extensions/api/OWNERS:4: bolms@chromium.org On 2012/08/03 12:13:26, battre wrote: > Ben ...

8 years, 4 months ago (2012-08-03 12:21:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10834151/5001

8 years, 4 months ago (2012-08-06 07:43:02 UTC) #7

Change committed as 150079

Expand Messages | Collapse Messages