[options2] Fix issue when deleting a user and pressing back.

[options2] Fix issue when deleting a user and pressing back.

R=estade@chromium.org
BUG=140224
TEST=Add user, delete user, press back button (manage profile should show).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150476

[Dan Beam, 2012-08-03 17:45:30]

I should note it might be worth adding a #create or #edit hash to the URL as
this currently works but perhaps create and edit aren't the same UI someday...

[Evan Stade, 2012-08-03 17:48:06]

ideally I think that history should just ignore the delete overlay. (back should
not go to manage profile). Is that hard to achieve?

[Dan Beam, 2012-08-03 18:25:42]

On 2012/08/03 17:48:06, Evan Stade wrote:
> ideally I think that history should just ignore the delete overlay. (back
should
> not go to manage profile). Is that hard to achieve?

it already does skip history.  the issue is that when you click "Add User" or
"Edit..." we pushState() a chrome://chrome/settings/manageProfile link into
history and this dialog has multiple states it can be in (create, edit, or
delete).  so, when done showing the delete dialog and back is pressed it
currently just re-displays the dialog with the previous state (which is wrong
when delete -> edit/create but OK in all other cases).

[Dan Beam, 2012-08-06 09:58:03]

ping for review tomorrow if we want this to get into M22 (cleanly)

[Evan Stade, 2012-08-07 04:57:11]

lgtm

https://chromiumcodereview.appspot.com/10834142/diff/8001/chrome/browser/reso...
File chrome/browser/resources/options2/manage_profile_overlay.css (right):

https://chromiumcodereview.appspot.com/10834142/diff/8001/chrome/browser/reso...
chrome/browser/resources/options2/manage_profile_overlay.css:7: min-width:
463px;
levae this stuff for another patch

[commit-bot: I haz the power, 2012-08-07 17:40:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10834142/9001

[commit-bot: I haz the power, 2012-08-07 18:57:23]

Change committed as 150381

[Dan Beam, 2012-08-07 21:31:31]

ptal

https://chromiumcodereview.appspot.com/10834142/diff/14001/chrome/browser/res...
File chrome/browser/resources/options2/manage_profile_overlay.js (right):

https://chromiumcodereview.appspot.com/10834142/diff/14001/chrome/browser/res...
chrome/browser/resources/options2/manage_profile_overlay.js:239: if
(cr.isChromeOS)
so apparently chromeos uses /accounts and hides this page (and doesn't even get
a profile model for the dialog).  I never tried it on chromeos nor does the try
bot run linux_chromeos:browser_tests... :(

[Evan Stade, 2012-08-07 21:59:22]

lgtm