Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: ui/views/bubble/bubble_border.h

Issue 10834140: aura: Fix launcher tooltips: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_border.h
diff --git a/ui/views/bubble/bubble_border.h b/ui/views/bubble/bubble_border.h
index 072a8066022d66b3af4928b3a0b4d5950af2179e..5ebb6198490c0f9d44b373b5668ee98043478508 100644
--- a/ui/views/bubble/bubble_border.h
+++ b/ui/views/bubble/bubble_border.h
@@ -118,7 +118,7 @@ class VIEWS_EXPORT BubbleBorder : public Border {
virtual void GetInsets(gfx::Insets* insets) const OVERRIDE;
// How many pixels the bubble border is from the edge of the images.
- int border_thickness() const;
+ virtual int border_thickness() const;
msw 2012/08/03 20:42:00 nit: this function shouldn't be hacker_style, it s
varunjain 2012/08/03 20:54:23 Done.
protected:
virtual ~BubbleBorder();
@@ -126,7 +126,7 @@ class VIEWS_EXPORT BubbleBorder : public Border {
// Calculates the insets for a specific arrow location. Normally called from
// GetInsets(arrow_location()), but may be called by specialized BubbleBorder
// implementations.
- void GetInsetsForArrowLocation(gfx::Insets* insets,
+ virtual void GetInsetsForArrowLocation(gfx::Insets* insets,
ArrowLocation arrow_loc) const;
msw 2012/08/03 20:42:00 nit: indent
varunjain 2012/08/03 20:54:23 Done.
private:

Powered by Google App Engine
This is Rietveld 408576698