Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10834138: We should grant read permission to the file returned by CreateFileSnapshot since the file must have… (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
Reviewers:
michaeln, tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam
Visibility:
Public.

Description

We should grant read permission to the file returned by CreateFileSnapshot since the file must have given for reading BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149798

Patch Set 1 : build fix! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/browser/fileapi/fileapi_message_filter.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
Can you take a look?
8 years, 4 months ago (2012-08-02 22:06:13 UTC) #1
michaeln
LGTM
8 years, 4 months ago (2012-08-03 01:35:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10834138/6003
8 years, 4 months ago (2012-08-03 04:18:25 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 07:19:00 UTC) #4
Change committed as 149798

Powered by Google App Engine
This is Rietveld 408576698