Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 10834137: Use empty string as the mid before it's ready from WebKit. Label is not the correct mid, so we shou… (Closed)

Created:
8 years, 4 months ago by Ronghua Wu (Left Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Use empty string as the mid before it's ready from WebKit. Label is not the correct mid, so we shouldn't use it, otherwise there will be a mismatch of mid and mline_index. BUG= http://code.google.com/p/webrtc/issues/detail?id=717 TEST=Test page from http://code.google.com/p/webrtc/issues/detail?id=717. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149754

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/renderer/media/media_stream_center.cc View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ronghua Wu (Left Chromium)
8 years, 4 months ago (2012-08-02 21:59:05 UTC) #1
wjia(left Chromium)
http://codereview.chromium.org/10834137/diff/3/content/renderer/media/media_stream_center.cc File content/renderer/media/media_stream_center.cc (right): http://codereview.chromium.org/10834137/diff/3/content/renderer/media/media_stream_center.cc#newcode151 content/renderer/media/media_stream_center.cc:151: const std::string sdp_mid = ""; std::string's default ctor make ...
8 years, 4 months ago (2012-08-02 22:09:19 UTC) #2
Ronghua Wu (Left Chromium)
http://codereview.chromium.org/10834137/diff/3/content/renderer/media/media_stream_center.cc File content/renderer/media/media_stream_center.cc (right): http://codereview.chromium.org/10834137/diff/3/content/renderer/media/media_stream_center.cc#newcode151 content/renderer/media/media_stream_center.cc:151: const std::string sdp_mid = ""; On 2012/08/02 22:09:20, wjia ...
8 years, 4 months ago (2012-08-02 22:14:47 UTC) #3
wjia(left Chromium)
lgtm
8 years, 4 months ago (2012-08-02 22:16:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/10834137/6001
8 years, 4 months ago (2012-08-02 22:31:39 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 00:57:38 UTC) #6
Change committed as 149754

Powered by Google App Engine
This is Rietveld 408576698