chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc - Issue 10834125: When committing a provisional load that didn't change the RVH, still abort pending navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc

Issue 10834125: When committing a provisional load that didn't change the RVH, still abort pending navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc b/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc

index 77ab10270f47fcce58696511d8873fbc0f9902cf..8e1f8cbd85de4cbe6420d21ddecf8a6249e45923 100644

--- a/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc

+++ b/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc

@@ -45,7 +45,8 @@ TEST(FrameNavigationStateTest, TrackFrame) {

EXPECT_EQ(frame_id1, navigation_state.GetMainFrameID());

// Drop the frames.

- navigation_state.StopTrackingFramesInRVH(fake_rvh);

+ navigation_state.StopTrackingFramesInRVH(fake_rvh,

+ FrameNavigationState::FrameID());

EXPECT_FALSE(navigation_state.CanSendEvents(frame_id1));

EXPECT_FALSE(navigation_state.IsValidFrame(frame_id1));

EXPECT_FALSE(navigation_state.CanSendEvents(frame_id2));