Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10834120: Drive: Add ALLOW_THIS_IN_INITIALIZER_LIST in operations_base.cc. (Closed)

Created:
8 years, 4 months ago by yoshiki
Modified:
8 years, 4 months ago
Reviewers:
achuithb, hashimoto
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Drive: Add ALLOW_THIS_IN_INITIALIZER_LIST in operations_base.cc. BUG=none TBR=hashimoto@chromium.org for a simple change adding ALLOW_THIS_IN_INITIALIZER_LIST. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/gdata/operations_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yoshiki
hashimoto: I forget to add ALLOW_THIS_IN_INITIALIZER_LIST in my previous check-in http://crrev.com/149140. This CL adds it. ...
8 years, 4 months ago (2012-08-01 23:56:09 UTC) #1
achuithb
lgtm
8 years, 4 months ago (2012-08-02 00:02:05 UTC) #2
hashimoto
lgtm
8 years, 4 months ago (2012-08-02 02:31:26 UTC) #3
hashimoto
On 2012/08/02 02:31:26, hashimoto wrote: > lgtm BTW, ALLOW_THIS_IN_INITIALIZER_LIST has no effect unless the code ...
8 years, 4 months ago (2012-08-02 03:17:43 UTC) #4
yoshiki
8 years, 4 months ago (2012-08-02 06:43:24 UTC) #5
On 2012/08/02 03:17:43, hashimoto wrote:
> On 2012/08/02 02:31:26, hashimoto wrote:
> > lgtm
> 
> BTW, ALLOW_THIS_IN_INITIALIZER_LIST has no effect unless the code gets
compiled
> by MSVC.
> Basically, you don't have to care about it in chromeos/

Yes, I know. But I think it'd be better to use it even in gdata code  to keep
consistency. Thanks.

Powered by Google App Engine
This is Rietveld 408576698