Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Side by Side Diff: chrome/browser/resources/options2/chromeos/proxy_rules_list.js

Issue 10834109: Consistently decorate pref values sent to the settings UI code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Silly me, made a CrOS-only change and tested it on a desktop build... Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.proxyexceptions', function() { 5 cr.define('options.proxyexceptions', function() {
6 /** @const */ var List = cr.ui.List; 6 /** @const */ var List = cr.ui.List;
7 /** @const */ var ListItem = cr.ui.ListItem; 7 /** @const */ var ListItem = cr.ui.ListItem;
8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
9 9
10 /** 10 /**
(...skipping 16 matching lines...) Expand all
27 // HACK(arv): http://crbug.com/40902 27 // HACK(arv): http://crbug.com/40902
28 window.addEventListener('resize', this.redraw.bind(this)); 28 window.addEventListener('resize', this.redraw.bind(this));
29 29
30 this.addEventListener('click', this.handleClick_); 30 this.addEventListener('click', this.handleClick_);
31 31
32 var self = this; 32 var self = this;
33 33
34 // Listens to pref changes. 34 // Listens to pref changes.
35 Preferences.getInstance().addEventListener(this.pref, 35 Preferences.getInstance().addEventListener(this.pref,
36 function(event) { 36 function(event) {
37 self.load_(event.value); 37 self.load_(event.value.value);
38 }); 38 });
39 }, 39 },
40 40
41 createItem: function(exception) { 41 createItem: function(exception) {
42 return new ProxyExceptionsItem(exception); 42 return new ProxyExceptionsItem(exception);
43 }, 43 },
44 44
45 /** 45 /**
46 * Adds given exception to model and update backend. 46 * Adds given exception to model and update backend.
47 * @param {Object} exception A exception to be added to exception list. 47 * @param {Object} exception A exception to be added to exception list.
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 labelException.className = ''; 130 labelException.className = '';
131 labelException.textContent = this.exception; 131 labelException.textContent = this.exception;
132 this.appendChild(labelException); 132 this.appendChild(labelException);
133 } 133 }
134 }; 134 };
135 135
136 return { 136 return {
137 ProxyExceptions: ProxyExceptions 137 ProxyExceptions: ProxyExceptions
138 }; 138 };
139 }); 139 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options2/chromeos/network_list.js ('k') | chrome/browser/resources/options2/pref_ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698