Consistently decorate pref values sent to the settings UI code

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 466 matching lines @@
 
     /**
      * Event listener for the 'session.restore_on_startup' pref.
      * @param {Event} event The preference change event.
      * @private
      */
     onRestoreOnStartupChanged_: function(event) {
       /** @const */ var showPagesValue = Number($('startup-show-pages').value);
       /** @const */ var showHomePageValue = 0;
 
-      $('startup-set-pages').disabled = event.value['disabled'] &&
-                                        event.value['value'] != showPagesValue;
+      $('startup-set-pages').disabled = event.value.disabled &&
+                                        event.value.value != showPagesValue;
 
-      if (event.value['value'] == showHomePageValue) {
+      if (event.value.value == showHomePageValue) {
         // If the user previously selected "Show the homepage", the
         // preference will already be migrated to "Open a specific page". So
         // the only way to reach this code is if the 'restore on startup'
         // preference is managed.
-        assert(event.value['controlledBy']);
+        assert(event.value.controlledBy);
 
         // Select "open the following pages" and lock down the list of URLs
         // to reflect the intention of the policy.
         $('startup-show-pages').checked = true;
         StartupOverlay.getInstance().setControlsDisabled(true);
       } else {
         // Re-enable the controls in the startup overlay if necessary.
         StartupOverlay.getInstance().updateControlStates();
       }
     },
@@ skipping 172 matching lines @@
     /**
      * Event listener for the 'show home button' preference. Shows/hides the
      * UI for changing the home page with animation, unless this is the first
      * time this function is called, in which case there is no animation.
      * @param {Event} event The preference change event.
      */
     onShowHomeButtonChanged_: function(event) {
       var section = $('change-home-page-section');
       if (this.onShowHomeButtonChangedCalled_) {
         var container = $('change-home-page-section-container');
-        if (event.value['value'])
+        if (event.value.value)
           this.showSectionWithAnimation_(section, container);
         else
           this.hideSectionWithAnimation_(section, container);
       } else {
-        section.hidden = !event.value['value'];
+        section.hidden = !event.value.value;
         this.onShowHomeButtonChangedCalled_ = true;
       }
     },
 
     /**
      * Event listener for the 'homepage is NTP' preference. Updates the label
      * next to the 'Change' button.
      * @param {Event} event The preference change event.
      */
     onHomePageIsNtpChanged_: function(event) {
-      $('home-page-url').hidden = event.value['value'];
-      $('home-page-ntp').hidden = !event.value['value'];
+      $('home-page-url').hidden = event.value.value;
+      $('home-page-ntp').hidden = !event.value.value;
     },
 
     /**
      * Event listener for changes to the homepage preference. Updates the label
      * next to the 'Change' button.
      * @param {Event} event The preference change event.
      */
     onHomePageChanged_: function(event) {
-      $('home-page-url').textContent = this.stripHttp_(event.value['value']);
+      $('home-page-url').textContent = this.stripHttp_(event.value.value);
     },
 
     /**
      * Removes the 'http://' from a URL, like the omnibox does. If the string
      * doesn't start with 'http://' it is returned unchanged.
      * @param {string} url The url to be processed
      * @return {string} The url with the 'http://' removed.
      */
     stripHttp_: function(url) {
       return url.replace(/^http:\/\//, '');
     },
 
    /**
     * Shows the autoLaunch preference and initializes its checkbox value.
     * @param {bool} enabled Whether autolaunch is enabled or or not.
     * @private
     */
     updateAutoLaunchState_: function(enabled) {
       $('auto-launch-option').hidden = false;
       $('auto-launch').checked = enabled;
     },
 
     /**
      * Called when the value of the instant.confirm_dialog_shown preference
      * changes. Cache this value.
      * @param {Event} event Change event.
      * @private
      */
     onInstantConfirmDialogShownChanged_: function(event) {
-      this.instantConfirmDialogShown_ = event.value['value'];
+      this.instantConfirmDialogShown_ = event.value.value;
     },
 
     /**
      * Called when the value of the spellcheck.confirm_dialog_shown preference
      * changes. Cache this value.
      * @param {Event} event Change event.
      * @private
      */
     onSpellcheckConfirmDialogShownChanged_: function(event) {
-      this.spellcheckConfirmDialogShown_ = event.value['value'];
+      this.spellcheckConfirmDialogShown_ = event.value.value;
     },
 
     /**
      * Called when the value of the download.default_directory preference
      * changes.
      * @param {Event} event Change event.
      * @private
      */
     onDefaultDownloadDirectoryChanged_: function(event) {
-      $('downloadLocationPath').value = event.value['value'];
+      $('downloadLocationPath').value = event.value.value;
       if (cr.isChromeOS) {
         // On ChromeOS, strip out /special for drive paths, and
         // /home/chronos/user for local files.
         $('downloadLocationPath').value = $('downloadLocationPath').value.
             replace(/^\/(special|home\/chronos\/user)/, '');
       }
     },
 
     /**
      * Update the Default Browsers section based on the current state.
@@ skipping 570 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });