Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10834099: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/automation/testing_automation_provider.h" 5 #include "chrome/browser/automation/testing_automation_provider.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 21 matching lines...) Expand all
32 #include "chrome/browser/autofill/personal_data_manager.h" 32 #include "chrome/browser/autofill/personal_data_manager.h"
33 #include "chrome/browser/autofill/personal_data_manager_factory.h" 33 #include "chrome/browser/autofill/personal_data_manager_factory.h"
34 #include "chrome/browser/automation/automation_browser_tracker.h" 34 #include "chrome/browser/automation/automation_browser_tracker.h"
35 #include "chrome/browser/automation/automation_provider_json.h" 35 #include "chrome/browser/automation/automation_provider_json.h"
36 #include "chrome/browser/automation/automation_provider_list.h" 36 #include "chrome/browser/automation/automation_provider_list.h"
37 #include "chrome/browser/automation/automation_provider_observers.h" 37 #include "chrome/browser/automation/automation_provider_observers.h"
38 #include "chrome/browser/automation/automation_tab_tracker.h" 38 #include "chrome/browser/automation/automation_tab_tracker.h"
39 #include "chrome/browser/automation/automation_util.h" 39 #include "chrome/browser/automation/automation_util.h"
40 #include "chrome/browser/automation/automation_window_tracker.h" 40 #include "chrome/browser/automation/automation_window_tracker.h"
41 #include "chrome/browser/bookmarks/bookmark_model.h" 41 #include "chrome/browser/bookmarks/bookmark_model.h"
42 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
42 #include "chrome/browser/bookmarks/bookmark_storage.h" 43 #include "chrome/browser/bookmarks/bookmark_storage.h"
43 #include "chrome/browser/browser_process.h" 44 #include "chrome/browser/browser_process.h"
44 #include "chrome/browser/browser_shutdown.h" 45 #include "chrome/browser/browser_shutdown.h"
45 #include "chrome/browser/browsing_data/browsing_data_helper.h" 46 #include "chrome/browser/browsing_data/browsing_data_helper.h"
46 #include "chrome/browser/browsing_data/browsing_data_remover.h" 47 #include "chrome/browser/browsing_data/browsing_data_remover.h"
47 #include "chrome/browser/content_settings/host_content_settings_map.h" 48 #include "chrome/browser/content_settings/host_content_settings_map.h"
48 #include "chrome/browser/debugger/devtools_window.h" 49 #include "chrome/browser/debugger/devtools_window.h"
49 #include "chrome/browser/download/download_prefs.h" 50 #include "chrome/browser/download/download_prefs.h"
50 #include "chrome/browser/download/download_service.h" 51 #include "chrome/browser/download/download_service.h"
51 #include "chrome/browser/download/download_service_factory.h" 52 #include "chrome/browser/download/download_service_factory.h"
(...skipping 1303 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 } 1356 }
1356 1357
1357 void TestingAutomationProvider::GetBookmarksAsJSON( 1358 void TestingAutomationProvider::GetBookmarksAsJSON(
1358 int handle, 1359 int handle,
1359 std::string* bookmarks_as_json, 1360 std::string* bookmarks_as_json,
1360 bool* success) { 1361 bool* success) {
1361 *success = false; 1362 *success = false;
1362 if (browser_tracker_->ContainsHandle(handle)) { 1363 if (browser_tracker_->ContainsHandle(handle)) {
1363 Browser* browser = browser_tracker_->GetResource(handle); 1364 Browser* browser = browser_tracker_->GetResource(handle);
1364 if (browser) { 1365 if (browser) {
1365 if (!browser->profile()->GetBookmarkModel()->IsLoaded()) { 1366 BookmarkModel* bookmark_model =
1367 BookmarkModelFactory::GetForProfile(browser->profile());
1368 if (!bookmark_model->IsLoaded()) {
1366 return; 1369 return;
1367 } 1370 }
1368 scoped_refptr<BookmarkStorage> storage(new BookmarkStorage( 1371 scoped_refptr<BookmarkStorage> storage(new BookmarkStorage(
1369 browser->profile(), 1372 browser->profile(), bookmark_model));
1370 browser->profile()->GetBookmarkModel()));
1371 *success = storage->SerializeData(bookmarks_as_json); 1373 *success = storage->SerializeData(bookmarks_as_json);
1372 } 1374 }
1373 } 1375 }
1374 } 1376 }
1375 1377
1376 void TestingAutomationProvider::WaitForBookmarkModelToLoad( 1378 void TestingAutomationProvider::WaitForBookmarkModelToLoad(
1377 int handle, 1379 int handle,
1378 IPC::Message* reply_message) { 1380 IPC::Message* reply_message) {
1379 if (browser_tracker_->ContainsHandle(handle)) { 1381 if (browser_tracker_->ContainsHandle(handle)) {
1380 Browser* browser = browser_tracker_->GetResource(handle); 1382 Browser* browser = browser_tracker_->GetResource(handle);
1381 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1383 BookmarkModel* model =
1384 BookmarkModelFactory::GetForProfile(browser->profile());
1382 if (model->IsLoaded()) { 1385 if (model->IsLoaded()) {
1383 AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams( 1386 AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams(
1384 reply_message, true); 1387 reply_message, true);
1385 Send(reply_message); 1388 Send(reply_message);
1386 } else { 1389 } else {
1387 // The observer will delete itself when done. 1390 // The observer will delete itself when done.
1388 new AutomationProviderBookmarkModelObserver(this, reply_message, 1391 new AutomationProviderBookmarkModelObserver(this, reply_message,
1389 model); 1392 model);
1390 } 1393 }
1391 } 1394 }
1392 } 1395 }
1393 1396
1394 void TestingAutomationProvider::AddBookmarkGroup(int handle, 1397 void TestingAutomationProvider::AddBookmarkGroup(int handle,
1395 int64 parent_id, 1398 int64 parent_id,
1396 int index, 1399 int index,
1397 std::wstring title, 1400 std::wstring title,
1398 bool* success) { 1401 bool* success) {
1399 if (browser_tracker_->ContainsHandle(handle)) { 1402 if (browser_tracker_->ContainsHandle(handle)) {
1400 Browser* browser = browser_tracker_->GetResource(handle); 1403 Browser* browser = browser_tracker_->GetResource(handle);
1401 if (browser) { 1404 if (browser) {
1402 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1405 BookmarkModel* model =
1406 BookmarkModelFactory::GetForProfile(browser->profile());
1403 if (!model->IsLoaded()) { 1407 if (!model->IsLoaded()) {
1404 *success = false; 1408 *success = false;
1405 return; 1409 return;
1406 } 1410 }
1407 const BookmarkNode* parent = model->GetNodeByID(parent_id); 1411 const BookmarkNode* parent = model->GetNodeByID(parent_id);
1408 DCHECK(parent); 1412 DCHECK(parent);
1409 if (parent) { 1413 if (parent) {
1410 const BookmarkNode* child = model->AddFolder(parent, index, 1414 const BookmarkNode* child = model->AddFolder(parent, index,
1411 WideToUTF16Hack(title)); 1415 WideToUTF16Hack(title));
1412 DCHECK(child); 1416 DCHECK(child);
1413 if (child) 1417 if (child)
1414 *success = true; 1418 *success = true;
1415 } 1419 }
1416 } 1420 }
1417 } 1421 }
1418 *success = false; 1422 *success = false;
1419 } 1423 }
1420 1424
1421 void TestingAutomationProvider::AddBookmarkURL(int handle, 1425 void TestingAutomationProvider::AddBookmarkURL(int handle,
1422 int64 parent_id, 1426 int64 parent_id,
1423 int index, 1427 int index,
1424 std::wstring title, 1428 std::wstring title,
1425 const GURL& url, 1429 const GURL& url,
1426 bool* success) { 1430 bool* success) {
1427 if (browser_tracker_->ContainsHandle(handle)) { 1431 if (browser_tracker_->ContainsHandle(handle)) {
1428 Browser* browser = browser_tracker_->GetResource(handle); 1432 Browser* browser = browser_tracker_->GetResource(handle);
1429 if (browser) { 1433 if (browser) {
1430 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1434 BookmarkModel* model =
1435 BookmarkModelFactory::GetForProfile(browser->profile());
1431 if (!model->IsLoaded()) { 1436 if (!model->IsLoaded()) {
1432 *success = false; 1437 *success = false;
1433 return; 1438 return;
1434 } 1439 }
1435 const BookmarkNode* parent = model->GetNodeByID(parent_id); 1440 const BookmarkNode* parent = model->GetNodeByID(parent_id);
1436 DCHECK(parent); 1441 DCHECK(parent);
1437 if (parent) { 1442 if (parent) {
1438 const BookmarkNode* child = model->AddURL(parent, index, 1443 const BookmarkNode* child = model->AddURL(parent, index,
1439 WideToUTF16Hack(title), url); 1444 WideToUTF16Hack(title), url);
1440 DCHECK(child); 1445 DCHECK(child);
1441 if (child) 1446 if (child)
1442 *success = true; 1447 *success = true;
1443 } 1448 }
1444 } 1449 }
1445 } 1450 }
1446 *success = false; 1451 *success = false;
1447 } 1452 }
1448 1453
1449 void TestingAutomationProvider::ReparentBookmark(int handle, 1454 void TestingAutomationProvider::ReparentBookmark(int handle,
1450 int64 id, 1455 int64 id,
1451 int64 new_parent_id, 1456 int64 new_parent_id,
1452 int index, 1457 int index,
1453 bool* success) { 1458 bool* success) {
1454 if (browser_tracker_->ContainsHandle(handle)) { 1459 if (browser_tracker_->ContainsHandle(handle)) {
1455 Browser* browser = browser_tracker_->GetResource(handle); 1460 Browser* browser = browser_tracker_->GetResource(handle);
1456 if (browser) { 1461 if (browser) {
1457 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1462 BookmarkModel* model =
1463 BookmarkModelFactory::GetForProfile(browser->profile());
1458 if (!model->IsLoaded()) { 1464 if (!model->IsLoaded()) {
1459 *success = false; 1465 *success = false;
1460 return; 1466 return;
1461 } 1467 }
1462 const BookmarkNode* node = model->GetNodeByID(id); 1468 const BookmarkNode* node = model->GetNodeByID(id);
1463 DCHECK(node); 1469 DCHECK(node);
1464 const BookmarkNode* new_parent = model->GetNodeByID(new_parent_id); 1470 const BookmarkNode* new_parent = model->GetNodeByID(new_parent_id);
1465 DCHECK(new_parent); 1471 DCHECK(new_parent);
1466 if (node && new_parent) { 1472 if (node && new_parent) {
1467 model->Move(node, new_parent, index); 1473 model->Move(node, new_parent, index);
1468 *success = true; 1474 *success = true;
1469 } 1475 }
1470 } 1476 }
1471 } 1477 }
1472 *success = false; 1478 *success = false;
1473 } 1479 }
1474 1480
1475 void TestingAutomationProvider::SetBookmarkTitle(int handle, 1481 void TestingAutomationProvider::SetBookmarkTitle(int handle,
1476 int64 id, 1482 int64 id,
1477 std::wstring title, 1483 std::wstring title,
1478 bool* success) { 1484 bool* success) {
1479 if (browser_tracker_->ContainsHandle(handle)) { 1485 if (browser_tracker_->ContainsHandle(handle)) {
1480 Browser* browser = browser_tracker_->GetResource(handle); 1486 Browser* browser = browser_tracker_->GetResource(handle);
1481 if (browser) { 1487 if (browser) {
1482 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1488 BookmarkModel* model =
1489 BookmarkModelFactory::GetForProfile(browser->profile());
1483 if (!model->IsLoaded()) { 1490 if (!model->IsLoaded()) {
1484 *success = false; 1491 *success = false;
1485 return; 1492 return;
1486 } 1493 }
1487 const BookmarkNode* node = model->GetNodeByID(id); 1494 const BookmarkNode* node = model->GetNodeByID(id);
1488 DCHECK(node); 1495 DCHECK(node);
1489 if (node) { 1496 if (node) {
1490 model->SetTitle(node, WideToUTF16Hack(title)); 1497 model->SetTitle(node, WideToUTF16Hack(title));
1491 *success = true; 1498 *success = true;
1492 } 1499 }
1493 } 1500 }
1494 } 1501 }
1495 *success = false; 1502 *success = false;
1496 } 1503 }
1497 1504
1498 void TestingAutomationProvider::SetBookmarkURL(int handle, 1505 void TestingAutomationProvider::SetBookmarkURL(int handle,
1499 int64 id, 1506 int64 id,
1500 const GURL& url, 1507 const GURL& url,
1501 bool* success) { 1508 bool* success) {
1502 if (browser_tracker_->ContainsHandle(handle)) { 1509 if (browser_tracker_->ContainsHandle(handle)) {
1503 Browser* browser = browser_tracker_->GetResource(handle); 1510 Browser* browser = browser_tracker_->GetResource(handle);
1504 if (browser) { 1511 if (browser) {
1505 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1512 BookmarkModel* model =
1513 BookmarkModelFactory::GetForProfile(browser->profile());
1506 if (!model->IsLoaded()) { 1514 if (!model->IsLoaded()) {
1507 *success = false; 1515 *success = false;
1508 return; 1516 return;
1509 } 1517 }
1510 const BookmarkNode* node = model->GetNodeByID(id); 1518 const BookmarkNode* node = model->GetNodeByID(id);
1511 DCHECK(node); 1519 DCHECK(node);
1512 if (node) { 1520 if (node) {
1513 model->SetURL(node, url); 1521 model->SetURL(node, url);
1514 *success = true; 1522 *success = true;
1515 } 1523 }
1516 } 1524 }
1517 } 1525 }
1518 *success = false; 1526 *success = false;
1519 } 1527 }
1520 1528
1521 void TestingAutomationProvider::RemoveBookmark(int handle, 1529 void TestingAutomationProvider::RemoveBookmark(int handle,
1522 int64 id, 1530 int64 id,
1523 bool* success) { 1531 bool* success) {
1524 if (browser_tracker_->ContainsHandle(handle)) { 1532 if (browser_tracker_->ContainsHandle(handle)) {
1525 Browser* browser = browser_tracker_->GetResource(handle); 1533 Browser* browser = browser_tracker_->GetResource(handle);
1526 if (browser) { 1534 if (browser) {
1527 BookmarkModel* model = browser->profile()->GetBookmarkModel(); 1535 BookmarkModel* model =
1536 BookmarkModelFactory::GetForProfile(browser->profile());
1528 if (!model->IsLoaded()) { 1537 if (!model->IsLoaded()) {
1529 *success = false; 1538 *success = false;
1530 return; 1539 return;
1531 } 1540 }
1532 const BookmarkNode* node = model->GetNodeByID(id); 1541 const BookmarkNode* node = model->GetNodeByID(id);
1533 DCHECK(node); 1542 DCHECK(node);
1534 if (node) { 1543 if (node) {
1535 const BookmarkNode* parent = node->parent(); 1544 const BookmarkNode* parent = node->parent();
1536 DCHECK(parent); 1545 DCHECK(parent);
1537 model->Remove(parent, parent->GetIndexOf(node)); 1546 model->Remove(parent, parent->GetIndexOf(node));
(...skipping 5546 matching lines...) Expand 10 before | Expand all | Expand 10 after
7084 void TestingAutomationProvider::OnRemoveProvider() { 7093 void TestingAutomationProvider::OnRemoveProvider() {
7085 if (g_browser_process) 7094 if (g_browser_process)
7086 g_browser_process->GetAutomationProviderList()->RemoveProvider(this); 7095 g_browser_process->GetAutomationProviderList()->RemoveProvider(this);
7087 } 7096 }
7088 7097
7089 void TestingAutomationProvider::EnsureTabSelected(Browser* browser, 7098 void TestingAutomationProvider::EnsureTabSelected(Browser* browser,
7090 WebContents* tab) { 7099 WebContents* tab) {
7091 if (chrome::GetActiveWebContents(browser) != tab) 7100 if (chrome::GetActiveWebContents(browser) != tab)
7092 chrome::ActivateTabAt(browser, chrome::GetIndexOfTab(browser, tab), true); 7101 chrome::ActivateTabAt(browser, chrome::GetIndexOfTab(browser, tab), true);
7093 } 7102 }
OLDNEW
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | chrome/browser/browser_commands_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698