Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/chromeos/gdata/gdata_files.h

Issue 10834093: gdata: Make RemoveEntry/TakeEntry/TakeOverEntries private (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_files.h
diff --git a/chrome/browser/chromeos/gdata/gdata_files.h b/chrome/browser/chromeos/gdata/gdata_files.h
index f7defe7a328a772136abeff1eaa33e2ea964c19a..b238bec41dc11e8b2370be3ebf1b140b702dbd8a 100644
--- a/chrome/browser/chromeos/gdata/gdata_files.h
+++ b/chrome/browser/chromeos/gdata/gdata_files.h
@@ -279,18 +279,6 @@ class GDataDirectory : public GDataEntry {
bool FromProto(const GDataDirectoryProto& proto) WARN_UNUSED_RESULT;
void ToProto(GDataDirectoryProto* proto) const;
- // Takes the ownership of |entry| from its current parent. If this directory
- // is already the current parent of |file|, this method effectively goes
- // through the name de-duplication for |file| based on the current state of
- // the file system.
- bool TakeEntry(GDataEntry* entry);
-
- // Takes over all entries from |dir|.
- bool TakeOverEntries(GDataDirectory* dir);
-
- // Removes the entry from its children list and destroys the entry instance.
- bool RemoveEntry(GDataEntry* entry);
-
// Removes child elements.
void RemoveChildren();
void RemoveChildFiles();
@@ -314,6 +302,21 @@ class GDataDirectory : public GDataEntry {
// TODO(satorux): Remove this. crbug.com/139649
void AddEntry(GDataEntry* entry);
+ // Removes the entry from its children list and destroys the entry instance.
+ // TODO(satorux): Remove this. crbug.com/139649
+ bool RemoveEntry(GDataEntry* entry);
+
+ // Takes the ownership of |entry| from its current parent. If this directory
+ // is already the current parent of |file|, this method effectively goes
+ // through the name de-duplication for |file| based on the current state of
+ // the file system.
+ // TODO(satorux): Remove this. crbug.com/139649
+ bool TakeEntry(GDataEntry* entry);
+
+ // Takes over all entries from |dir|.
+ // TODO(satorux): Remove this. crbug.com/139649
+ bool TakeOverEntries(GDataDirectory* dir);
+
// Find a child by its name.
// TODO(satorux): Remove this. crbug.com/139649
GDataEntry* FindChild(const FilePath::StringType& file_name) const;
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698