Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10834089: Update perf expecations for Linux-64 (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)
Modified:
8 years, 4 months ago
Reviewers:
sail, James Simonsen
CC:
chromium-reviews, pam+watch_chromium.org, srikanth
Visibility:
Public.

Description

Update perf expecations for Linux-64 BUG=139835 NOTRY=TRUE TBR=simonjam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149217

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
James, I don't know if these changes are good, i.e. are these regressions, or just ...
8 years, 4 months ago (2012-07-31 17:44:19 UTC) #1
sail
lgtm
8 years, 4 months ago (2012-07-31 17:45:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10834089/1
8 years, 4 months ago (2012-07-31 17:48:27 UTC) #3
commit-bot: I haz the power
Change committed as 149217
8 years, 4 months ago (2012-07-31 17:51:05 UTC) #4
James Simonsen
https://chromiumcodereview.appspot.com/10834089/diff/1/tools/perf_expectations/perf_expectations.json File tools/perf_expectations/perf_expectations.json (left): https://chromiumcodereview.appspot.com/10834089/diff/1/tools/perf_expectations/perf_expectations.json#oldcode3 tools/perf_expectations/perf_expectations.json:3: "linux-release-64/sizes/chrome-si/initializers": {"reva": 145035, "revb": 145035, "type": "absolute", "better": "lower", ...
8 years, 4 months ago (2012-07-31 17:59:03 UTC) #5
vandebo (ex-Chrome)
8 years, 4 months ago (2012-07-31 18:01:08 UTC) #6
https://chromiumcodereview.appspot.com/10834089/diff/1/tools/perf_expectation...
File tools/perf_expectations/perf_expectations.json (left):

https://chromiumcodereview.appspot.com/10834089/diff/1/tools/perf_expectation...
tools/perf_expectations/perf_expectations.json:3:
"linux-release-64/sizes/chrome-si/initializers": {"reva": 145035, "revb":
145035, "type": "absolute", "better": "lower", "improve": 43, "regress": 43,
"tolerance": 0, "sha1": "fa5fa232"},
On 2012/07/31 17:59:03, James Simonsen wrote:
> I think Android will be upset about the new static initializers. CC'ing one of
> the leads. I think we'll have to track down where this came from.

Oops, that's supposed to be the chrome-data line, not the chrome-si line.  Will
fix.

Powered by Google App Engine
This is Rietveld 408576698