Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10834086: Remove file without license header and fix file flags of non-executable .py file. (Closed)

Created:
8 years, 4 months ago by battre
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Remove file without license header and fix file flags of non-executable .py file. BUG=112155 TBR=mark@chromium.org NOTRY=TRUE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/re2/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/re2/patches/remove-testinstall.cc-and-fix-filepermissions.patch View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/re2/re2/unicode.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/re2/testinstall.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10834086/1
8 years, 4 months ago (2012-07-31 15:04:25 UTC) #1
commit-bot: I haz the power
Change committed as 149183
8 years, 4 months ago (2012-07-31 15:04:41 UTC) #2
Mark Mentovai
LGTM, although if the check-licenses script actually cares about such trivial nonsense in third_party, it ...
8 years, 4 months ago (2012-07-31 22:28:20 UTC) #3
battre
8 years, 4 months ago (2012-08-01 09:09:45 UTC) #4
On 2012/07/31 22:28:20, Mark Mentovai wrote:
> LGTM, although if the check-licenses script actually cares about such trivial
> nonsense in third_party, it should either be fixed or if you can convince the
> upstream to add a license block to the file, that’s another option.

I have filed a bug upstream already.

Powered by Google App Engine
This is Rietveld 408576698