Check for an error handle passed in, in all dart_api functions that return a handle. Pass the erro…

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1891 matching lines @@
 DART_EXPORT Dart_Handle Dart_ListGetAt(Dart_Handle list, intptr_t index) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(list));
   if (obj.IsArray()) {
     GET_LIST_ELEMENT(isolate, Array, obj, index);
   }
   if (obj.IsGrowableObjectArray()) {
     GET_LIST_ELEMENT(isolate, GrowableObjectArray, obj, index);
   }
+  if (obj.IsError()) {

[Ivan Posva, 2012/08/21 02:48:45]

How about making this into an if-elsif chain?

[Bill Hesse, 2012/08/23 11:17:44]

Done.

+    return list;
+  }
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance =
       Instance::Handle(isolate, GetListInstance(isolate, obj));
   if (!instance.IsNull()) {
     String& name = String::Handle(isolate, String::New("[]"));
     const Function& function =
         Function::Handle(isolate,
                          Resolver::ResolveDynamic(instance, name, 2, 0));
     if (!function.IsNull()) {
       GrowableArray<const Object*> args(1);
       Integer& indexobj = Integer::Handle(isolate);
       indexobj = Integer::New(index);
       args.Add(&indexobj);
       const Array& kNoArgumentNames = Array::Handle(isolate);
       return Api::NewHandle(
           isolate,
           DartEntry::InvokeDynamic(instance, function, args, kNoArgumentNames));
     }
   }
   return Api::NewError("Object does not implement the 'List' interface");
 }
 
 
 #define SET_LIST_ELEMENT(isolate, type, obj, index, value)                     \
   const type& array = type::Cast(obj);                                         \
   const Object& value_obj = Object::Handle(isolate, Api::UnwrapHandle(value)); \
+  if (!value_obj.IsNull() && !value_obj.IsInstance()) {                        \
+    RETURN_TYPE_ERROR(isolate, value, Instance);                               \
+  }                                                                            \
   if ((index >= 0) && (index < array.Length())) {                              \
     array.SetAt(index, value_obj);                                             \
     return Api::Success(isolate);                                              \
   }                                                                            \
   return Api::NewError("Invalid index passed in to set list element");         \
 
 
 DART_EXPORT Dart_Handle Dart_ListSetAt(Dart_Handle list,
                                        intptr_t index,
                                        Dart_Handle value) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(list));
   if (obj.IsArray()) {
     if (obj.IsImmutableArray()) {
       return Api::NewError("Cannot modify immutable array");
     }
     SET_LIST_ELEMENT(isolate, Array, obj, index, value);
   }
   if (obj.IsGrowableObjectArray()) {
     SET_LIST_ELEMENT(isolate, GrowableObjectArray, obj, index, value);
   }
+  if (obj.IsError()) {

[Ivan Posva, 2012/08/21 02:48:45]

ditto: if-elsif chain

[Bill Hesse, 2012/08/23 11:17:44]

Done.

+    return list;
+  }
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance =
       Instance::Handle(isolate, GetListInstance(isolate, obj));
   if (!instance.IsNull()) {
     String& name = String::Handle(isolate, String::New("[]="));
     const Function& function =
         Function::Handle(isolate,
                          Resolver::ResolveDynamic(instance, name, 3, 0));
     if (!function.IsNull()) {
       const Integer& index_obj = Integer::Handle(isolate, Integer::New(index));
       const Object& value_obj =
           Object::Handle(isolate, Api::UnwrapHandle(value));
+      if (!value_obj.IsNull() && !value_obj.IsInstance()) {
+        RETURN_TYPE_ERROR(isolate, value, Instance);
+      }
+      if (value_obj.IsError()) {
+        return value;

[Ivan Posva, 2012/08/21 02:48:45]

How will this "return value" ever be reached? As far as I can see you already
returned above with a RETURN_TYPE_ERROR because value_obj is not null and it is
not an instance.

[Bill Hesse, 2012/08/23 11:17:44]

Correct.  Removed. 
On 2012/08/21 02:48:45, Ivan Posva wrote:

+      }
       GrowableArray<const Object*> args(2);
       args.Add(&index_obj);
       args.Add(&value_obj);
       const Array& kNoArgumentNames = Array::Handle(isolate);
       return Api::NewHandle(
           isolate,
           DartEntry::InvokeDynamic(instance, function, args, kNoArgumentNames));
     }
   }
   return Api::NewError("Object does not implement the 'List' interface");
@@ skipping 43 matching lines @@
                               native_array,
                               offset,
                               length);  }
   if (obj.IsGrowableObjectArray()) {
     GET_LIST_ELEMENT_AS_BYTES(isolate,
                               GrowableObjectArray,
                               obj,
                               native_array,
                               offset,
                               length);
   }

[Ivan Posva, 2012/08/21 02:48:45]

ditto: if-elsif chain

[Bill Hesse, 2012/08/23 11:17:44]

Done.

+  if (obj.IsError()) {
+    return list;
+  }
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance =
       Instance::Handle(isolate, GetListInstance(isolate, obj));
   if (!instance.IsNull()) {
     String& name = String::Handle(isolate, String::New("[]"));
     const Function& function =
         Function::Handle(isolate,
                          Resolver::ResolveDynamic(instance, name, 2, 0));
     if (!function.IsNull()) {
       Object& result = Object::Handle(isolate);
@@ skipping 66 matching lines @@
                               offset,
                               length);
   }
   if (obj.IsGrowableObjectArray()) {
     SET_LIST_ELEMENT_AS_BYTES(isolate,
                               GrowableObjectArray,
                               obj,
                               native_array,
                               offset,
                               length);
   }

[Ivan Posva, 2012/08/21 02:48:45]

ditto

+  if (obj.IsError()) {
+    return list;
+  }
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance =
       Instance::Handle(isolate, GetListInstance(isolate, obj));
   if (!instance.IsNull()) {
     String& name = String::Handle(isolate, String::New("[]="));
     const Function& function =
         Function::Handle(isolate,
                          Resolver::ResolveDynamic(instance, name, 3, 0));
     if (!function.IsNull()) {
       Integer& indexobj = Integer::Handle(isolate);
@@ skipping 255 matching lines @@
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(object));
   return obj.IsClosure();
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClosureFunction(Dart_Handle closure) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(closure));
-  if (obj.IsNull()) {
-    return Api::NewError("Null object passed to Dart_ClosureFunction");
-  }
-  if (!obj.IsClosure()) {
-    return Api::NewError("Invalid closure passed to Dart_ClosureFunction");
+  const Closure& closure_obj = Api::UnwrapClosureHandle(isolate, closure);
+  if (closure_obj.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, closure, Closure);
   }
   ASSERT(ClassFinalizer::AllClassesFinalized());
 
-  const Closure& closure_obj = Closure::Cast(obj);
   RawFunction* rf = closure_obj.function();
   return Api::NewHandle(isolate, rf);
 }
 
 
 DART_EXPORT Dart_Handle Dart_InvokeClosure(Dart_Handle closure,
                                            int number_of_arguments,
                                            Dart_Handle* arguments) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(closure));
-  if (obj.IsNull()) {
-    return Api::NewError("Null object passed in to invoke closure");
+  const Closure& closure_obj = Api::UnwrapClosureHandle(isolate, closure);
+  if (closure_obj.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, closure, Closure);
   }
-  if (!obj.IsClosure()) {
-    return Api::NewError("Invalid closure passed to invoke closure");
+  if (number_of_arguments < 0) {
+    return Api::NewError(
+        "%s expects argument 'number_of_arguments' to be non-negative.",
+        CURRENT_FUNC);
   }
   ASSERT(ClassFinalizer::AllClassesFinalized());
 
   // Now try to invoke the closure.
-  const Closure& closure_obj = Closure::Cast(obj);
   GrowableArray<const Object*> dart_arguments(number_of_arguments);
   for (int i = 0; i < number_of_arguments; i++) {
     const Object& arg =
         Object::Handle(isolate, Api::UnwrapHandle(arguments[i]));
+    if (!arg.IsNull() && !arg.IsInstance()) {
+      RETURN_TYPE_ERROR(isolate, arguments[i], Instance);
+    }
     dart_arguments.Add(&arg);
   }
   const Array& kNoArgumentNames = Array::Handle(isolate);
   return Api::NewHandle(
       isolate,
       DartEntry::InvokeClosure(closure_obj, dart_arguments, kNoArgumentNames));
 }
 
 
 DART_EXPORT int64_t Dart_ClosureSmrck(Dart_Handle object) {
@@ skipping 37 matching lines @@
   if (obj.IsClass()) {
     return Class::Cast(obj).is_interface();
   }
   return false;
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClassName(Dart_Handle clazz) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  const Class& cls = Api::UnwrapClassHandle(isolate, clazz);

[Bill Hesse, 2012/08/16 11:54:13]

Am I missing somethigng here?  Is there a reason to make two handles, or is this
just to create a non-const handle (which we don't need here).

[turnidge, 2012/08/17 18:23:40]

The new code you've written here looks better.  I see no good reason for the
existing code to have the weird double-handle thing.

   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
   const String& cls_name = String::Handle(isolate, cls.Name());
   return Api::NewHandle(isolate, IdentifierPrettyName(isolate, cls_name));
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClassGetLibrary(Dart_Handle clazz) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  const Class& cls = Api::UnwrapClassHandle(isolate, clazz);
   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
 
 #if defined(DEBUG)
   const Library& lib = Library::Handle(cls.library());
   if (lib.IsNull()) {
     ASSERT(cls.IsDynamicClass() || cls.IsVoidClass());
   }
 #endif
 
   return Api::NewHandle(isolate, cls.library());
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClassGetDefault(Dart_Handle clazz) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  const Class& cls = Api::UnwrapClassHandle(isolate, clazz);
   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
 
   // Finalize all classes.
   const char* msg = CheckIsolateState(isolate);
   if (msg != NULL) {
     return Api::NewError(msg);
   }
 
   if (cls.HasFactoryClass() && cls.HasResolvedFactoryClass()) {
     return Api::NewHandle(isolate, cls.FactoryClass());
   }
   return Api::Null(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClassGetInterfaceCount(Dart_Handle clazz,
                                                     intptr_t* count) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  const Class& cls = Api::UnwrapClassHandle(isolate, clazz);
   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
 
   const Array& interface_types = Array::Handle(isolate, cls.interfaces());
   if (interface_types.IsNull()) {
     *count = 0;
   } else {
     *count = interface_types.Length();
   }
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_ClassGetInterfaceAt(Dart_Handle clazz,
                                                  intptr_t index) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  const Class& cls = Api::UnwrapClassHandle(isolate, clazz);
   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
 
   // Finalize all classes.
   const char* msg = CheckIsolateState(isolate);
   if (msg != NULL) {
     return Api::NewError(msg);
   }
 
@@ skipping 515 matching lines @@
   DARTSCOPE(isolate);
   Object& result = Object::Handle(isolate);
 
   if (number_of_arguments < 0) {
     return Api::NewError(
         "%s expects argument 'number_of_arguments' to be non-negative.",
         CURRENT_FUNC);
   }
 
   // Get the class to instantiate.
-  Class& cls = Class::Handle(
-      isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
+  Class& cls =
+      Class::Handle(isolate, Api::UnwrapClassHandle(isolate, clazz).raw());
   if (cls.IsNull()) {
     RETURN_TYPE_ERROR(isolate, clazz, Class);
   }
   String& base_constructor_name = String::Handle();
   base_constructor_name = cls.Name();
 
   // And get the name of the constructor to invoke.
   String& dot_name = String::Handle(isolate);
   const Object& name_obj =
       Object::Handle(isolate, Api::UnwrapHandle(constructor_name));
   if (name_obj.IsNull()) {
     dot_name = Symbols::Dot();
   } else if (name_obj.IsString()) {
     const String& dot = String::Handle(isolate, Symbols::Dot());
     dot_name = String::Concat(dot, String::Cast(name_obj));
   } else {
-    return Api::NewError(
-        "%s expects argument 'constructor_name' to be of type String.",
-        CURRENT_FUNC);
+    RETURN_TYPE_ERROR(isolate, constructor_name, String);
   }
 
   const char* msg = CheckIsolateState(isolate);
   if (msg != NULL) {
     return Api::NewError(msg);
   }
 
   // Check for interfaces with default implementations.
   if (cls.is_interface()) {
     // Make sure that the constructor is found in the interface.
@@ skipping 232 matching lines @@
 
 DART_EXPORT Dart_Handle Dart_GetField(Dart_Handle container, Dart_Handle name) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
 
   const String& field_name = Api::UnwrapStringHandle(isolate, name);
   if (field_name.IsNull()) {
     RETURN_TYPE_ERROR(isolate, name, String);
   }
 
   const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(container));

[Ivan Posva, 2012/08/21 02:48:45]

This pattern really calls for a Api::UnwrapObjectHandle helper method as well.
Maybe in a follow up CL?

 
   Field& field = Field::Handle(isolate);
   Function& getter = Function::Handle(isolate);
   if (obj.IsNull()) {
     return Api::NewError("%s expects argument 'container' to be non-null.",
                          CURRENT_FUNC);
   } else if (obj.IsInstance()) {
     // Every instance field has a getter Function.  Try to find the
     // getter in any superclass and use that function to access the
     // field.
@@ skipping 77 matching lines @@
       const Array& kNoArgNames = Array::Handle(isolate);
       return Api::NewHandle(
           isolate, DartEntry::InvokeStatic(getter, args, kNoArgNames));
     } else if (!field.IsNull()) {
       return Api::NewHandle(isolate, field.value());
     } else {
       return Api::NewError("%s: did not find top-level variable '%s'.",
                            CURRENT_FUNC, field_name.ToCString());
     }
 
+  } else if (obj.IsError()) {
+      return container;
   } else {
     return Api::NewError(
         "%s expects argument 'container' to be an object, class, or library.",
         CURRENT_FUNC);
   }
 }
 
 
 DART_EXPORT Dart_Handle Dart_SetField(Dart_Handle container,
                                       Dart_Handle name,
@@ skipping 121 matching lines @@
                              CURRENT_FUNC, field_name.ToCString());
       } else {
         field.set_value(value_instance);
         return Api::Success(isolate);
       }
     } else {
       return Api::NewError("%s: did not find top-level variable '%s'.",
                            CURRENT_FUNC, field_name.ToCString());
     }
 
+  } else if (obj.IsError()) {
+      return container;
   } else {
     return Api::NewError(
         "%s expects argument 'container' to be an object, class, or library.",
         CURRENT_FUNC);
   }
 }
 
 
 DART_EXPORT Dart_Handle Dart_CreateNativeWrapperClass(Dart_Handle library,
                                                       Dart_Handle name,
                                                       int field_count) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Object& param = Object::Handle(isolate, Api::UnwrapHandle(name));
-  if (param.IsNull() || !param.IsString() || field_count <= 0) {
+  const String& cls_name = Api::UnwrapStringHandle(isolate, name);
+  if (cls_name.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, name, String);
+  }
+  Library& lib = Library::Handle(isolate,
+      Api::UnwrapLibraryHandle(isolate, library).raw());
+  if (lib.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, library, Library);
+  }
+  if (field_count <= 0) {
     return Api::NewError(
-        "Invalid arguments passed to Dart_CreateNativeWrapperClass");
+        "Negative field_count passed to Dart_CreateNativeWrapperClass");
   }
-  String& cls_name = String::Handle(isolate);
-  cls_name ^= param.raw();
-  cls_name = Symbols::New(cls_name);
-  Library& lib = Library::Handle(isolate);
-  lib ^= Api::UnwrapHandle(library);
-  if (lib.IsNull()) {
-    return Api::NewError(
-        "Invalid arguments passed to Dart_CreateNativeWrapperClass");
-  }
+
+  String& cls_symbol = String::Handle(isolate, Symbols::New(cls_name));
   const Class& cls = Class::Handle(
-      isolate, Class::NewNativeWrapper(&lib, cls_name, field_count));
+      isolate, Class::NewNativeWrapper(&lib, cls_symbol, field_count));

[Ivan Posva, 2012/08/21 02:48:45]

This should have never expected a Library*. I am changing this in an independent
CL to expect a const Library& and then you should be able to use
Api::UnwrapLibraryHandle above.

https://chromiumcodereview.appspot.com/10827434

[Bill Hesse, 2012/08/23 11:17:44]

Done.

   if (cls.IsNull()) {
     return Api::NewError(
         "Unable to create native wrapper class : already exists");
   }
   return Api::NewHandle(isolate, cls.raw());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetNativeInstanceFieldCount(Dart_Handle obj,
                                                          int* count) {
@@ skipping 46 matching lines @@
   return Api::Success(isolate);
 }
 
 
 // --- Exceptions ----
 
 
 DART_EXPORT Dart_Handle Dart_ThrowException(Dart_Handle exception) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
+  const Instance& excp = Api::UnwrapInstanceHandle(isolate, exception);
+  if (excp.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, exception, Instance);
+  }
   if (isolate->top_exit_frame_info() == 0) {
     // There are no dart frames on the stack so it would be illegal to
     // throw an exception here.
     return Api::NewError("No Dart frames on stack, cannot throw exception");
   }
-  const Instance& excp =
-      Instance::CheckedHandle(isolate, Api::UnwrapHandle(exception));
   // Unwind all the API scopes till the exit frame before throwing an
   // exception.
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   state->UnwindScopes(isolate->top_exit_frame_info());
   Exceptions::Throw(excp);
   return Api::NewError("Exception was not thrown, internal error");
 }
 
 
 DART_EXPORT Dart_Handle Dart_ReThrowException(Dart_Handle exception,
                                               Dart_Handle stacktrace) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
+  DARTSCOPE(isolate);
+  const Instance& excp = Api::UnwrapInstanceHandle(isolate, exception);
+  if (excp.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, exception, Instance);
+  }
+  const Instance& stk = Api::UnwrapInstanceHandle(isolate, stacktrace);
+  if (stk.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, stacktrace, Instance);
+  }
   if (isolate->top_exit_frame_info() == 0) {
     // There are no dart frames on the stack so it would be illegal to
     // throw an exception here.
     return Api::NewError("No Dart frames on stack, cannot throw exception");
   }
-  DARTSCOPE(isolate);
-  const Instance& excp =
-      Instance::CheckedHandle(isolate, Api::UnwrapHandle(exception));
-  const Instance& stk =
-      Instance::CheckedHandle(isolate, Api::UnwrapHandle(stacktrace));
   // Unwind all the API scopes till the exit frame before throwing an
   // exception.
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   state->UnwindScopes(isolate->top_exit_frame_info());
   Exceptions::ReThrow(excp, stk);
   return Api::NewError("Exception was not re thrown, internal error");
 }
 
 
@@ skipping 425 matching lines @@
 DART_EXPORT void Dart_InitPerfEventsSupport(Dart_FileWriterFunction function) {
   Dart::set_perf_events_writer(function);
 }
 
 
 DART_EXPORT void Dart_InitFlowGraphPrinting(Dart_FileWriterFunction function) {
   Dart::set_flow_graph_writer(function);
 }
 
 }  // namespace dart