chrome/browser/extensions/extension_install_prompt.cc - Issue 10834082: Pass through Extension::FROM_WEBSTORE to Extension::Create when installing an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 10834082: Pass through Extension::FROM_WEBSTORE to Extension::Create when installing an (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: remove IWYU import fix, could cause cherry-pick problems if we do that Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('K') | « chrome/browser/extensions/extension_install_prompt.h ('k') | chrome/browser/extensions/webstore_inline_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_prompt.cc

diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc

index df63791cd866e277d11f56107199da65c421dffd..b65f1326541dd18ed64cfbc0de1e51be46887714 100644

--- a/chrome/browser/extensions/extension_install_prompt.cc

+++ b/chrome/browser/extensions/extension_install_prompt.cc

@@ -232,6 +232,7 @@ const IssueAdviceInfoEntry& ExtensionInstallPrompt::Prompt::GetOAuthIssue(

scoped_refptr<Extension>

ExtensionInstallPrompt::GetLocalizedExtensionForDisplay(

const DictionaryValue* manifest,

+ int flags,

const std::string& id,

const std::string& localized_name,

const std::string& localized_description,

@@ -253,7 +254,7 @@ scoped_refptr<Extension>

FilePath(),

Extension::INTERNAL,

localized_manifest.get() ? *localized_manifest.get() : *manifest,

- Extension::NO_FLAGS,

+ flags,

id,

error);

}