Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10834077: [UMA] Add " (Metro)" to the OS name for UMA uploads from Chrome running under Windows 8's Metro mod… (Closed)

Created:
8 years, 4 months ago by Ilya Sherman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Visibility:
Public.

Description

[UMA] Add " (Metro)" to the OS name for UMA uploads from Chrome running under Windows 8's Metro mode. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149953

Patch Set 1 #

Patch Set 2 : Added a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/metrics/metrics_log.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
This is probably the simplest way to make this change. The other easy option is ...
8 years, 4 months ago (2012-07-31 00:08:19 UTC) #1
jar (doing other things)
lgtm
8 years, 4 months ago (2012-07-31 21:32:58 UTC) #2
MAD
LGTM too... Thanks! BYE MAD...
8 years, 4 months ago (2012-07-31 22:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10834077/1
8 years, 4 months ago (2012-08-03 20:38:28 UTC) #4
Ilya Sherman
MAD, added a TODO (and corresponding bug) for you to evaluate how to split on ...
8 years, 4 months ago (2012-08-03 21:07:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10834077/5002
8 years, 4 months ago (2012-08-03 21:07:40 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 22:39:41 UTC) #7
Change committed as 149953

Powered by Google App Engine
This is Rietveld 408576698