Refactor WebIntentsRegistry internals to use closures as WebDataService results handlers.

Refactor WebIntentsRegistry internals to use closures as WebDataService results handlers.

BUG=137907
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149289

[Steve McKay, 2012-07-31 00:33:30]

K. Ready for a looksee.

[Steve McKay, 2012-07-31 15:56:28]

Reassigning to Greg since Rachel is OOO.

[Greg Billock, 2012-07-31 19:10:03]

On 2012/07/31 15:56:28, Steve McKay wrote:
> Reassigning to Greg since Rachel is OOO.

lgtm. Nice! Looks great.

[Greg Billock, 2012-07-31 19:10:09]

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
File chrome/browser/intents/web_intents_registry.cc (right):

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
chrome/browser/intents/web_intents_registry.cc:158: // Internal object
containing arguments to used in post processing
to be used

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
chrome/browser/intents/web_intents_registry.cc:184: // Internal object adapter
the WDS consumer interface to an easier
for the

[Steve McKay, 2012-07-31 19:14:35]

Dones. Thanks!

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
File chrome/browser/intents/web_intents_registry.cc (right):

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
chrome/browser/intents/web_intents_registry.cc:158: // Internal object
containing arguments to used in post processing
On 2012/07/31 19:10:09, Greg Billock wrote:
> to be used

Done.

http://codereview.chromium.org/10834076/diff/1004/chrome/browser/intents/web_...
chrome/browser/intents/web_intents_registry.cc:184: // Internal object adapter
the WDS consumer interface to an easier
On 2012/07/31 19:10:09, Greg Billock wrote:
> for the

Reworded.

[commit-bot: I haz the power, 2012-07-31 19:16:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10834076/11001

[commit-bot: I haz the power, 2012-07-31 19:38:43]

Try job failure for 10834076-11001 (retry) (retry) on mac_rel for steps
"base_unittests, browser_tests, cacheinvalidation_unittests, jingle_unittests,
remoting_unittests, interactive_ui_tests, crypto_unittests, net_unittests,
unit_tests, gpu_unittests, nacl_integration, media_unittests,
safe_browsing_tests, ipc_tests, printing_unittests, sql_unittests,
content_unittests, sync_unit_tests".
It's a second try, previously, steps "base_unittests, browser_tests,
cacheinvalidation_unittests, jingle_unittests, remoting_unittests,
interactive_ui_tests, crypto_unittests, net_unittests, unit_tests,
gpu_unittests, nacl_integration, media_unittests, safe_browsing_tests,
ipc_tests, printing_unittests, sql_unittests, content_unittests,
sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-31 20:33:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10834076/11001

[commit-bot: I haz the power, 2012-07-31 22:03:33]

Change committed as 149289