Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10834064: x64 BinaryOpStub uses wrong registers in one code path (Closed)

Created:
8 years, 4 months ago by Zheng Liu
Modified:
8 years, 4 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

R=yangguo@chromium.org,svenpanne@chromium.org x64 BinaryOpStub::GenerateSmiCode use wrong registers in one code path. e.g. d8 --trace_ic var dd = new Float64Array(2); dd[1] = 1; (function fn() { for (var i = 0; i < 1000; i++) dd[0] = 2 / dd[1]; })(); It keeps falling into runtime call and patching. No regression test, because I don't how to test it. Committed: https://code.google.com/p/v8/source/detail?r=12226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/x64/code-stubs-x64.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zheng Liu
PTAL
8 years, 4 months ago (2012-07-30 11:50:41 UTC) #1
Yang
8 years, 4 months ago (2012-07-30 13:03:39 UTC) #2
On 2012/07/30 11:50:41, Zheng Liu wrote:
> PTAL

LGTM. There indeed doesn't seem to be any simple way to create a regression test
for this. I'm landing the patch.

Powered by Google App Engine
This is Rietveld 408576698